Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncToRecs should be not async #1238

Closed
holic opened this issue Aug 3, 2023 · 1 comment · Fixed by #1315
Closed

syncToRecs should be not async #1238

holic opened this issue Aug 3, 2023 · 1 comment · Fixed by #1315
Assignees

Comments

@holic
Copy link
Member

holic commented Aug 3, 2023

We want to guarantee the returned streams haven't started yet and async reveals possible foot-guns

@holic
Copy link
Member Author

holic commented Aug 13, 2023

Found another issue where our React template expect to await the network setup before rendering anything, but now the network setup fetches/hydrates from the indexer before returning, so the React app won't render anything until after the initial fetch.

This probably explains either the black or white screen in Sky Strife cc @Kooshaba @yonadaaa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2 participants