Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployer should throw if table ID exists with diff schema #3207

Open
holic opened this issue Sep 19, 2024 · 1 comment
Open

deployer should throw if table ID exists with diff schema #3207

holic opened this issue Sep 19, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@holic
Copy link
Member

holic commented Sep 19, 2024

we currently skip existing tables

debug("existing tables:", existingTables.map(resourceToLabel).join(", "));

which is good if the table is the shape we expect, because they're considered immutable

but if you were to override a table schema in your config, this should throw an error rather than skipping, to help teach that table schemas are immutable

@holic
Copy link
Member Author

holic commented Sep 19, 2024

you could sorta work around this in latest MUD with labels: you give it a different table name but leave the table label alone (so table libs end up the same, just the table ID changes), that way a new table is deployed with the new schema (it'd be empty though)

@holic holic changed the title deployer should throw if trying to modify an existing table deployer should throw if table ID exists with diff schema Sep 19, 2024
@holic holic added the good first issue Good for newcomers label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

1 participant