Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store-sync,store-indexer): consolidate sync logic, add syncToSqlite #1240

Merged
merged 20 commits into from
Aug 15, 2023

Conversation

holic
Copy link
Member

@holic holic commented Aug 3, 2023

closes #1142

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

🦋 Changeset detected

Latest commit: 992a3d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@latticexyz/dev-tools Minor
@latticexyz/store-indexer Minor
@latticexyz/store-sync Minor
@latticexyz/block-logs-stream Minor
@latticexyz/cli Minor
@latticexyz/common Minor
@latticexyz/config Minor
create-mud Minor
@latticexyz/ecs-browser Minor
@latticexyz/gas-report Minor
@latticexyz/network Minor
@latticexyz/noise Minor
@latticexyz/phaserx Minor
@latticexyz/protocol-parser Minor
@latticexyz/react Minor
@latticexyz/recs Minor
@latticexyz/schema-type Minor
@latticexyz/services Minor
@latticexyz/solecs Minor
solhint-config-mud Minor
solhint-plugin-mud Minor
@latticexyz/std-client Minor
@latticexyz/std-contracts Minor
@latticexyz/store-cache Minor
@latticexyz/store Minor
@latticexyz/utils Minor
@latticexyz/world Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic changed the title WIP sync to sqlite feat(store-sync,store-indexer): consolidate sync logic, add syncToSqlite Aug 15, 2023
@holic holic marked this pull request as ready for review August 15, 2023 10:00
@holic holic requested a review from alvrs as a code owner August 15, 2023 10:00
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🚢

Comment on lines +17 to +18
// case "EphemeralRecord":
// return <span className="text-violet-400 font-bold">~</span>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the plan to add EphemeralRecord as a separate StorageOperation or abstract it one level higher?

Copy link
Member Author

@holic holic Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't decided 🙈 any opinions?

Right now ephemeral records get collapsed/treated as SetRecord storage operations, but I can see the argument for exposing both and maybe our own adapters just treat them the same before inserting into RECS/SQLite.

We don't distinguish them from each other when hydrating from the indexer, so it makes it a little weird/tricky to know what the current state ought to be.

@holic holic merged commit 753bdce into main Aug 15, 2023
@holic holic deleted the holic/sync-to-sqlite branch August 15, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sql based datastore for table data
2 participants