-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store-sync,store-indexer): consolidate sync logic, add syncToSqlite #1240
Conversation
🦋 Changeset detectedLatest commit: 992a3d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! 🚢
// case "EphemeralRecord": | ||
// return <span className="text-violet-400 font-bold">~</span>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the plan to add EphemeralRecord
as a separate StorageOperation
or abstract it one level higher?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't decided 🙈 any opinions?
Right now ephemeral records get collapsed/treated as SetRecord
storage operations, but I can see the argument for exposing both and maybe our own adapters just treat them the same before inserting into RECS/SQLite.
We don't distinguish them from each other when hydrating from the indexer, so it makes it a little weird/tricky to know what the current state ought to be.
closes #1142