Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split runtime and tls features #1630

Open
msdrigg opened this issue Jan 15, 2022 · 2 comments
Open

Split runtime and tls features #1630

msdrigg opened this issue Jan 15, 2022 · 2 comments

Comments

@msdrigg
Copy link

msdrigg commented Jan 15, 2022

Recently the issue forcing the weird combined runtime+tls feature was just resolved. (I don't think it lands till 1.59)

Is there a policy or a general guideline here for MSRV? Maybe this needs to wait a while if so, but just wanted to make sure yall knew that there are good changes coming soon.

rust-lang/cargo#10269

@abonander
Copy link
Collaborator

As a policy, we don't track an MSRV: https://github.com/launchbadge/sqlx/blob/master/FAQ.md#what-versions-of-rust-does-sqlx-support-what-is-sqlxs-msrv

To be nice, I try not to use features that are too new unless there's a compelling reason, but since this would be a significant change to optional features it would make sense to do in 0.6.0 anyway.

@msdrigg
Copy link
Author

msdrigg commented Jan 17, 2022

Sweet! I haven't worked at all with cargo features, so I won't be much help writing a PR for this, but I am glad this is moving forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants