Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros: don't reference serde_json::Value directly #1840

Closed
abonander opened this issue Apr 29, 2022 · 0 comments · Fixed by #1842
Closed

Macros: don't reference serde_json::Value directly #1840

abonander opened this issue Apr 29, 2022 · 0 comments · Fixed by #1842
Labels

Comments

@abonander
Copy link
Collaborator

The macros can emit code directly referencing serde_json::Value which may trigger compilation errors if the user doesn't have it in their own dependencies: https://discord.com/channels/665528275556106240/665528275556106243/969377568685981716

I'm surprised we haven't encountered this before now, probably because if someone wants to use serde_json::Value in their code deliberately then they probably already have serde_json in their dependencies.

Easy fix, though:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant