Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool should spawn a task when connecting in acquire() #3513

Open
abonander opened this issue Sep 20, 2024 · 0 comments · May be fixed by #3582
Open

Pool should spawn a task when connecting in acquire() #3513

abonander opened this issue Sep 20, 2024 · 0 comments · May be fixed by #3582
Labels
E-medium enhancement New feature or request good first issue Good for newcomers pool Related to SQLx's included connection pool

Comments

@abonander
Copy link
Collaborator

This way, if the acquire() call is cancelled or times out, the connection can still go through.

The connection task should have its own separate timeout, possibly surfaced as PoolOptions::connect_timeout().

This will likely fix:

@abonander abonander added enhancement New feature or request good first issue Good for newcomers E-medium pool Related to SQLx's included connection pool labels Sep 20, 2024
@abonander abonander linked a pull request Oct 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-medium enhancement New feature or request good first issue Good for newcomers pool Related to SQLx's included connection pool
Projects
None yet
1 participant