Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query! macros should allow for a trailing comma #105

Closed
mehcode opened this issue Feb 1, 2020 · 2 comments · Fixed by #109
Closed

query! macros should allow for a trailing comma #105

mehcode opened this issue Feb 1, 2020 · 2 comments · Fixed by #109
Assignees
@abonander
Labels
bug good first issue Good for newcomers

Comments

@mehcode
Copy link
Member

mehcode commented Feb 1, 2020

No description provided.

@mehcode mehcode added the bug label Feb 1, 2020
@mehcode mehcode changed the title query! macros should allow for a trailing slash query! macros should allow for a trailing comma Feb 1, 2020
@mehcode mehcode mentioned this issue Feb 1, 2020
Merged
@abonander abonander added the good first issue Good for newcomers label Feb 1, 2020
@tim-harding
Copy link
Contributor

I'd like to take a shot at this if it isn't already taken.

@abonander
Copy link
Collaborator

@timmythetiny be our guest! I've got instructions for the intended fix here: #90 (comment)

@tim-harding tim-harding mentioned this issue Feb 8, 2020
Merged
abonander added a commit that referenced this issue Feb 21, 2020
@abonander
Merge pull request #109 from timmythetiny/ab/trailing-comma-fix
18a925f 
Fix #105, allow trailing commas in query macros
janaakhterov pushed a commit that referenced this issue Mar 4, 2020
@janaakhterov
Fix #105, allow trailing commas in query macros
4a3360f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abonander abonander

Labels
bug good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #105, allow trailing commas in query macros tim-harding/sqlx
3 participants
@mehcode @abonander @tim-harding