From f74260dae5bc127e3c9d7e021ea9cd72e9159931 Mon Sep 17 00:00:00 2001 From: Casey Waldren Date: Mon, 11 Sep 2023 13:46:08 -0700 Subject: [PATCH] chore: resolve ValidChar function lint/compile warnings (#234) (#242) The argument to `ValidChar` is a `char`, so its max value is `255` rendering the check redundant. This causes a warning on our Mac compilations as well as a linter warning. Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> --- libs/common/src/config/app_info_builder.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libs/common/src/config/app_info_builder.cpp b/libs/common/src/config/app_info_builder.cpp index df83d2749..69f163a86 100644 --- a/libs/common/src/config/app_info_builder.cpp +++ b/libs/common/src/config/app_info_builder.cpp @@ -21,9 +21,9 @@ tl::expected AppInfoBuilder::Tag::Build() const { } bool ValidChar(char c) { - if(c > 0 && c < 255) { - // The MSVC implementation of isalnum will assert if the number it outside - // its lookup table. + if (c > 0) { + // The MSVC implementation of isalnum will assert if the number is + // outside its lookup table (0-0xFF, inclusive.) // iswalnum would not, but is less restrictive than desired. return std::isalnum(c) != 0 || c == '-' || c == '.' || c == '_'; }