fix: make passing of LD_NONBLOCKING in C bindings consistent #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/consistent-blocking
branch
from
0be8039 to
f00dd49
Compare
cwaldren-ld
commented
May 23, 2023
| @@ -118,7 +120,7 @@ LDClientSDK_Identify(LDClientSDK sdk, LDContext context, int milliseconds) { | |||
|
|
|||
| LDContext_Free(context); | |||
|
|
|||
| if (milliseconds < 0) { | |||
| if (milliseconds == LD_NONBLOCKING) { | |||
| return; | |||
| } | |||
There was a problem hiding this comment.
We could also just call wait_for with 0, but I believe there's no guarantee that won't block for some tiny amount of time.
kinyoklion
approved these changes
May 23, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the asynchronous methods (
Flush/Identify) were taking a signed int milliseconds argument, where negative represented nonblocking, and 0/positive numbers were a delay.This reduces the state to simply 0/positive numbers.
LD_NONBLOCKINGis defined as 0. There's no point having a 3rd state for nonblocking.