-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Version method to obtain SDK version #122
Conversation
This pull request has been linked to Shortcut Story #204904: Add version method. |
821cb8d
to
a1f2c06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think a public static method would be more convenient. Because then you don't need to create a client to know the SDK version.
Agreed. Will update. |
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 0.2.0</summary> ## [0.2.0](launchdarkly-cpp-client-v0.1.0...launchdarkly-cpp-client-v0.2.0) (2023-05-31) ### Features * add AllFlags C binding ([#128](#128)) ([9aa0794](9aa0794)) * Add C bindings for data source status. ([#124](#124)) ([d175abb](d175abb)) * Add c bindings for FlagNotifier. ([#119](#119)) ([11a7f61](11a7f61)) * add Version method to obtain SDK version ([#122](#122)) ([1003117](1003117)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.1.0 to 0.1.1 * launchdarkly-cpp-common bumped from 0.1.0 to 0.2.0 </details> <details><summary>launchdarkly-cpp-common: 0.2.0</summary> ## [0.2.0](launchdarkly-cpp-common-v0.1.0...launchdarkly-cpp-common-v0.2.0) (2023-05-31) ### Features * add AllFlags C binding ([#128](#128)) ([9aa0794](9aa0794)) * Add C bindings for data source status. ([#124](#124)) ([d175abb](d175abb)) * Add c bindings for FlagNotifier. ([#119](#119)) ([11a7f61](11a7f61)) * Allow for easier creation of contexts from existing contexts. ([#130](#130)) ([5e18616](5e18616)) ### Bug Fixes * rename C iterator bindings to follow new/free pattern ([#129](#129)) ([24dff9a](24dff9a)) </details> <details><summary>launchdarkly-cpp-internal: 0.1.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-common bumped from 0.1.0 to 0.2.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Adds a
Version/LDClientSDK_Version
method, which exposes the client's version via function call.In the previous way, it was a public static class member. This way, we have a bit more encapsulation and can also expose it via C binding.