feat: make EvaluationReason use enums for Kind and ErrorKind #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #199918: Create nice enums for flag evaluation errors. |
cwaldren-ld
changed the title
cwaldren-ld
commented
May 5, 2023
kinyoklion
reviewed
May 5, 2023
kinyoklion
reviewed
May 5, 2023
| if (str == "ERROR") { | ||
| return EvaluationReason::Kind::kError; | ||
| } | ||
| return tl::make_unexpected(JsonError::kSchemaFailure); |
There was a problem hiding this comment.
This makes me nervous, but I guess we are locked into this contract forever already.
This was referenced May 8, 2023
This was referenced May 10, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
EvaluationReason's error and error_kind members to be enums instead of strings.They are serialized to and from JSON using the
tag_invokemechanism and switch/if-else chains.The "debug"
operator<<for each enum usesboost::json::value_fromunder the hood. This way we could theoretically have a different debug representation, and it wouldn't affect the actual constants that are part of the JSON schema.