Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Event FlagChanged doesn't trigger on creation a new flag #31

Closed
tomertr opened this issue Jun 30, 2021 · 2 comments
Closed

Event FlagChanged doesn't trigger on creation a new flag #31

tomertr opened this issue Jun 30, 2021 · 2 comments

Comments

@tomertr
Copy link

tomertr commented Jun 30, 2021

The event FlagChanged doesn't trigger on creation of a new flag, it only triggers on changes made to flags that already existed during the last query to AllFlags.

To reproduce
Register to the LdClient event FlagChanged then add a new flag to LaunchDarkly

Expected behavior
The event should be triggered on the new flag added

SDK version
Xamarin 1.2.0.0

OS/platform
Windows 10

@eli-darkly
Copy link
Contributor

Thanks for reporting this. I see where the flaw in the logic is, and it's pretty straightforward, so putting out a fix will only depend on our overall project/release pipeline which is a little backed up at the moment. I'll file it as low-hanging fruit to be addressed as soon as there's a chance.

@eli-darkly
Copy link
Contributor

Sorry for the lack of an update on this issue before. This behavior is fixed in the new 2.0.0 release, as part of its somewhat different flag change event API (basically, instead of LdClient.FlagChanged it is now LdClient.FlagTracker.FlagValueChanged and the name of the argument type has changed). We probably won't put out a 1.x patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants