Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare 2.18.3 release #222

Merged
merged 549 commits into from
Nov 17, 2020
Merged
Changes from 1 commit
Commits
Show all changes
549 commits
Select commit Hold shift + click to select a range
b6bbe01
Merge pull request #175 from launchdarkly/eb/ch35206/stringify-attrs
eli-darkly Apr 3, 2019
e266703
Merge pull request #176 from launchdarkly/eb/async-tests
eli-darkly Apr 5, 2019
39d3dbf
Merge pull request #177 from launchdarkly/eb/ch18858/anon-user-key
eli-darkly Apr 5, 2019
a098f2f
add more general HTTP abstraction, use Promises internally
eli-darkly Apr 9, 2019
ccb0836
eliminate some more uses of callbacks; update tests
eli-darkly Apr 9, 2019
288ea52
linter
eli-darkly Apr 9, 2019
adc301f
rm unused
eli-darkly Apr 9, 2019
e7fdc4e
fix init tests
eli-darkly Apr 9, 2019
9b096e4
fix init tests again
eli-darkly Apr 9, 2019
38d4e75
make stream init logic more reliable
eli-darkly Apr 10, 2019
2832c55
add another HTTP test
eli-darkly Apr 10, 2019
5d39679
better network errors
eli-darkly Apr 11, 2019
5d3aa4d
Merge branch 'master' into experiment
eli-darkly Apr 15, 2019
aea3145
support metric value in track()
eli-darkly Apr 15, 2019
2c0fed3
comment
eli-darkly Apr 16, 2019
bc15c00
Merge branch 'master' of github.com:launchdarkly/js-client
eli-darkly Apr 17, 2019
96f2e6d
update method description
eli-darkly Apr 17, 2019
343de29
Merge pull request #179 from launchdarkly/eb/ch33425/metric-value
eli-darkly Apr 17, 2019
d258337
Merge branch 'master' into eb/ch35956/http-cleanup
eli-darkly Apr 17, 2019
35eaa2f
Merge pull request #178 from launchdarkly/eb/ch35956/http-cleanup
eli-darkly Apr 17, 2019
0aadc83
refactor to isolate the sync XHR logic; expose close() method
eli-darkly Apr 17, 2019
9039f9f
rm unused
eli-darkly Apr 17, 2019
b88d3cb
fix broken readme links
bwoskow-ld Apr 18, 2019
33a3c8a
absolute links
bwoskow-ld Apr 18, 2019
cfc1326
clarify common package
bwoskow-ld Apr 18, 2019
5ef8675
Merge pull request #182 from launchdarkly/bw/fix-broken-readme-links
bwoskow-ld Apr 18, 2019
2032179
sync requests should never be retried
eli-darkly Apr 19, 2019
da8c8cc
Merge pull request #181 from launchdarkly/eb/ch36705/refactor-sync-xhr
eli-darkly Apr 19, 2019
e88e4a3
add script to publish docs to Github Pages
eli-darkly Apr 19, 2019
b059bb4
can't delete a directory while we're in it
eli-darkly Apr 19, 2019
148c235
fix a GH Pages configuration problem
eli-darkly Apr 19, 2019
b55794b
readme link to generated docs
eli-darkly Apr 19, 2019
dcb39ef
Merge pull request #183 from launchdarkly/eb/ch30937/publish-docs
eli-darkly Apr 19, 2019
c7c4e60
fix uuid dependency, add unit tests for user key
eli-darkly Apr 19, 2019
f827e41
linter
eli-darkly Apr 19, 2019
663b822
rm debugging
eli-darkly Apr 19, 2019
389f236
revert accidental change
eli-darkly Apr 19, 2019
036e31c
revert accidental change
eli-darkly Apr 19, 2019
4d624ab
Merge pull request #184 from launchdarkly/eb/ch18858/uuid-crypto-dep
eli-darkly Apr 19, 2019
25e3bc9
Merge branch 'master' into eb/ch35956/http-headers
eli-darkly Apr 19, 2019
6fb3f94
change HTTP response handling to avoid CORS header errors
eli-darkly Apr 19, 2019
cae70b4
Merge pull request #185 from launchdarkly/eb/ch35956/http-headers
eli-darkly Apr 20, 2019
503bebe
Merge branch 'master' of github.com:launchdarkly/js-client
eli-darkly Apr 20, 2019
8d48889
don't use Promise.finally()
eli-darkly Apr 23, 2019
dae51eb
Merge pull request #187 from launchdarkly/eb/ch37469/no-finally
eli-darkly Apr 23, 2019
2594bb7
Merge branch 'master' of github.com:launchdarkly/js-client
eli-darkly Apr 24, 2019
a46cc28
allow Electron and Node SDKs to report their own SDK version
eli-darkly Apr 27, 2019
7fa36af
Merge pull request #188 from launchdarkly/eb/ch37716/sdk-version
eli-darkly Apr 27, 2019
a143aab
apply markdown templates
bwoskow-ld Apr 30, 2019
14135aa
markdown fixes
bwoskow-ld Apr 30, 2019
d51c0a5
rename package ids
bwoskow-ld May 1, 2019
d2a28d2
add new JS SDK test/demo page
eli-darkly May 1, 2019
89e7ace
Merge pull request #189 from launchdarkly/bw/36771/apply-markdown-tem…
bwoskow-ld May 2, 2019
d84451e
misc doc edits
eli-darkly May 2, 2019
7a53f4a
Merge pull request #192 from launchdarkly/eb/doc-edits
eli-darkly May 2, 2019
20d3bb0
Merge branch 'master' of github.com:launchdarkly/js-client
eli-darkly May 2, 2019
1b5f965
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
bwoskow-ld May 3, 2019
d0d87ec
Merge pull request #190 from launchdarkly/bw/ch36754/rename-package-ids
bwoskow-ld May 3, 2019
4732080
Merge branch 'bw/36771/apply-markdown-templates' of github.com:launch…
bwoskow-ld May 4, 2019
8a00b23
fixing merge error
bwoskow-ld May 4, 2019
2b0ea42
fixing merge error
bwoskow-ld May 4, 2019
ddd30a2
fix broken links on npmjs.com (#193)
bwoskow-ld May 7, 2019
dc0045f
update lockfiles for new packages
eli-darkly May 8, 2019
d15517b
Merge branch 'master' of github.com:launchdarkly/js-client
eli-darkly May 8, 2019
f3bd889
fix changelog formatting error that messes up the release script
eli-darkly May 10, 2019
b016a78
Specify unpkg default target file in package.json for
gwhelanLD May 20, 2019
a1ceb4d
Merge pull request #195 from launchdarkly/gw/ch39115/unpkg-min-js
gwhelanLD May 20, 2019
ac1cf04
Correct requestor call to fetch flags on a received ping event.
gwhelanLD May 21, 2019
ffdbbb4
Merge pull request #197 from launchdarkly/gw/ch39114/ping-stream
gwhelanLD May 21, 2019
d258832
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
gwhelanLD May 22, 2019
5f6a2f8
merge from public after release
LaunchDarklyCI May 22, 2019
decb730
Implement Hooks API (#196)
yusinto May 22, 2019
51cc15c
bumping our lerna version to resolve transitive dependency vulnerabil…
bwoskow-ld May 31, 2019
49bbca2
Merge branch 'master' into experiment
eli-darkly Jun 6, 2019
c148884
merge from public after release
LaunchDarklyCI Jun 7, 2019
cb19f25
fix goals query logic for Electron, also fix handling of invalid cont…
eli-darkly Jun 14, 2019
a5cfb07
Merge pull request #199 from launchdarkly/eb/ch40967/electron-goals
eli-darkly Jun 17, 2019
cb9124e
add ability to alter URL in events
eli-darkly Jun 17, 2019
a532ce7
Merge pull request #200 from launchdarkly/eb/ch41207/url-path-prefix
eli-darkly Jun 18, 2019
bc95369
merge from public after release
LaunchDarklyCI Jun 18, 2019
4a609cb
Merge branch 'master' into experiment
eli-darkly Jun 18, 2019
d894e44
Update browserPlatform definition to detect when an EventSource
gwhelanLD Jun 19, 2019
ea142cd
Fix initial linter warnings.
gwhelanLD Jun 19, 2019
a3f3b71
Fix another linter warning.
gwhelanLD Jun 19, 2019
839400c
fix a broken readme link (#202)
bwoskow-ld Jun 25, 2019
72f84f7
removing a stray character in the readme
bwoskow-ld Jun 25, 2019
ad9de1f
fix stream reconnect logic and add stream connection logging
eli-darkly Jun 27, 2019
b5465ea
linter
eli-darkly Jun 27, 2019
cf2637a
assume logger always exists, as we do in other components
eli-darkly Jun 27, 2019
bbf8a69
Merge pull request #203 from launchdarkly/eb/ch42125/stream-reconnect
eli-darkly Jun 27, 2019
3903fd7
fix and simplify how the logger object is passed around
eli-darkly Jun 28, 2019
0bc0b22
Merge pull request #204 from launchdarkly/eb/ch42125/fix-loggers
eli-darkly Jun 28, 2019
5e64220
merge from public after release
LaunchDarklyCI Jun 28, 2019
5b5b16d
Merge branch 'master' into experiment
eli-darkly Jun 28, 2019
9b9de28
make it so eventUrlTransformer actually does something
eli-darkly Jun 29, 2019
5a3cffb
linter
eli-darkly Jun 29, 2019
850bf08
Merge pull request #205 from launchdarkly/eb/ch41207/fix-url-transform
eli-darkly Jun 29, 2019
e0dca4a
merge from public after release
LaunchDarklyCI Jun 29, 2019
cf99467
copy flags object to prevent subtle update problem in Electron
eli-darkly Jul 4, 2019
b9eaec5
additional fix + test
eli-darkly Jul 4, 2019
74f2ea5
make bootstrapped flags available immediately
eli-darkly Jul 8, 2019
1990aa3
Refactor some of the EventSource constructor selection logic.
gwhelanLD Jul 8, 2019
f99d9ed
Merge branch 'master' into gw/ch15353/report-stream
gwhelanLD Jul 8, 2019
ac65049
Merge pull request #207 from launchdarkly/eb/ch42598/immediate-bootstrap
eli-darkly Jul 8, 2019
712b590
Merge pull request #206 from launchdarkly/eb/ch42529/change-event
eli-darkly Jul 8, 2019
202498a
Change browserPlatform.js to check config options when determining
gwhelanLD Jul 8, 2019
855e547
Deal with linter.
gwhelanLD Jul 8, 2019
ef9d5e6
merge from public after release
LaunchDarklyCI Jul 8, 2019
a4a247e
Merge pull request #201 from launchdarkly/gw/ch15353/report-stream
gwhelanLD Jul 9, 2019
dba61bf
Merge branch 'master' into eb/ch37354/demo
eli-darkly Jul 9, 2019
7c322c8
change how supported options are detected in EventSource polyfill
eli-darkly Jul 9, 2019
1d20c38
Merge pull request #208 from launchdarkly/eb/ch15353/report-stream
eli-darkly Jul 10, 2019
edaab07
fix broken homepage attributes (#209)
bwoskow-ld Jul 10, 2019
efd4c2c
merge from public after release
LaunchDarklyCI Jul 11, 2019
08b705e
improve bad initialization messages (#210)
bwoskow-ld Jul 11, 2019
84ec55f
fixing a broken link in a logged message (#212)
bwoskow-ld Jul 18, 2019
fe08546
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
eli-darkly Jul 29, 2019
0189751
merge from public after release
LaunchDarklyCI Jul 29, 2019
fe930da
add jsdelivr attribute to js packages (#213)
bwoskow-ld Aug 1, 2019
d68a635
adding an option to disable the camel-casing of flag keys (#214)
bwoskow-ld Aug 12, 2019
ae8aa69
use persistent anonymous user logic by default in react sdk (#216)
bwoskow-ld Aug 12, 2019
810c684
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
bwoskow-ld Aug 15, 2019
05f854d
merge from public after release
LaunchDarklyCI Aug 15, 2019
a05309d
remove React package from monorepo
eli-darkly Sep 6, 2019
8ffd505
make link text match link
eli-darkly Sep 6, 2019
b8320c1
Merge pull request #218 from launchdarkly/eb/ch48625/remove-react
eli-darkly Sep 9, 2019
636e838
Merge branch 'master' of github.com:launchdarkly/js-client-sdk-privat…
zmdavis Sep 23, 2019
8fbdd87
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
eli-darkly Oct 2, 2019
3854728
improve log format and add configurable prefix
eli-darkly Oct 9, 2019
8005f13
fix test
eli-darkly Oct 9, 2019
9da6dd7
linter
eli-darkly Oct 9, 2019
ef238c4
Merge pull request #219 from launchdarkly/eb/ch52309/log-format
eli-darkly Oct 10, 2019
00d8142
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
eli-darkly Oct 10, 2019
46a015f
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
bwoskow-ld Oct 11, 2019
6683ad7
deprecate samplingInterval
eli-darkly Oct 17, 2019
cf35f0b
linter
eli-darkly Oct 17, 2019
12d18e5
Merge pull request #220 from launchdarkly/eb/ch38635/deprecate-sampling
eli-darkly Oct 17, 2019
7aa81f4
improve log message for stream connection failures (#221)
bwoskow-ld Oct 28, 2019
6d8216f
updating the js-common readme to mention client-side node (#222)
bwoskow-ld Oct 29, 2019
9e50339
remove common package, no more monorepo
eli-darkly Oct 30, 2019
7e09455
add Releaser metadata
eli-darkly Oct 30, 2019
a460085
npm audit fix
eli-darkly Oct 30, 2019
bdc72e7
unify Rollup config
eli-darkly Oct 30, 2019
fd45520
Merge branch 'master' into eb/ch37354/demo
eli-darkly Oct 31, 2019
9beb82f
migrate new demo code to new package structure
eli-darkly Oct 31, 2019
5af9fb6
moved example folder
eli-darkly Oct 31, 2019
d38871d
syntax fix in demo
eli-darkly Nov 4, 2019
4722400
fix directory name
eli-darkly Nov 4, 2019
70ea56a
fix linting
eli-darkly Nov 4, 2019
94a8bd1
Merge pull request #223 from launchdarkly/eb/ch48393/remove-common-pkg
eli-darkly Nov 4, 2019
6209205
use spread operator instead of Object.assign
eli-darkly Nov 4, 2019
227accd
Merge pull request #224 from launchdarkly/eb/ch54985/object-assign
eli-darkly Nov 4, 2019
4c6476f
don't close client on beforeunload, but do flush events
eli-darkly Nov 5, 2019
ce81189
typo
eli-darkly Nov 5, 2019
6c4728f
clarify test postconditions
eli-darkly Nov 5, 2019
d4c3b06
Merge pull request #225 from launchdarkly/eb/ch55109/beforeunload
eli-darkly Nov 5, 2019
c944bc6
Merge branch 'demo-new-build' into eb/ch37354/demo
eli-darkly Nov 5, 2019
7509e8c
Merge branch 'master' into eb/ch37354/demo
eli-darkly Nov 5, 2019
7547396
misc test app improvements for testing beforeunload handler
eli-darkly Nov 5, 2019
153f5ef
Merge pull request #191 from launchdarkly/eb/ch37354/demo
eli-darkly Nov 5, 2019
8e20332
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
eli-darkly Nov 5, 2019
5963c2f
merge from public after release
LaunchDarklyCI Nov 5, 2019
67bdf02
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
eli-darkly Nov 6, 2019
4c5ab24
rm unused yarn.lock
eli-darkly Nov 6, 2019
6c5f960
rm typedoc dependency, don't commit installation of it during release
eli-darkly Nov 6, 2019
95da8b3
fix paths
eli-darkly Nov 6, 2019
298ed11
fix file copying logic
eli-darkly Nov 6, 2019
8b5d084
Merge pull request #226 from launchdarkly/eb/ch55415/typedoc-dep
eli-darkly Nov 6, 2019
6fc3c94
merge from public after release
LaunchDarklyCI Nov 6, 2019
86299f9
pr template
bwoskow-ld Nov 7, 2019
c81d53a
revert
bwoskow-ld Nov 7, 2019
db369c8
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
bwoskow-ld Nov 7, 2019
f0ce0f8
fix programmatically reported version string
eli-darkly Nov 14, 2019
2965ba1
Merge pull request #227 from launchdarkly/eb/ch56237
eli-darkly Nov 14, 2019
34d9a0f
upgrade Typescript to avoid Typedoc incompatibility
eli-darkly Nov 15, 2019
5a04414
Revert "upgrade Typescript to avoid Typedoc incompatibility"
eli-darkly Nov 15, 2019
89438e5
update Babel, Jest, Rollup
eli-darkly Nov 15, 2019
c709922
Merge pull request #228 from launchdarkly/eb/ch56269/build-tools
eli-darkly Nov 15, 2019
f49c240
merge from public after release
LaunchDarklyCI Nov 15, 2019
3154c05
remove old releaser (#229)
bwoskow-ld Nov 26, 2019
5fe9de4
remove unused Rollup plugins, update dependencies
eli-darkly Dec 4, 2019
2ed1231
Merge pull request #230 from launchdarkly/eb/ch57982/rollup-plugins
eli-darkly Dec 4, 2019
301348b
use new config validation mechanism in js-sdk-common 3.x
eli-darkly Dec 11, 2019
1a04e46
Merge pull request #231 from launchdarkly/eb/ch57985/config-validation
eli-darkly Dec 12, 2019
d74e680
add image-loading event delivery logic factored out of js-sdk-common
eli-darkly Dec 12, 2019
e525b00
Merge branch 'master' into eb/ch59034/image-loading-events
eli-darkly Dec 12, 2019
f3330a7
enable diagnostic events in JS SDK
eli-darkly Dec 12, 2019
96791a1
lint
eli-darkly Dec 12, 2019
7787c59
fix tests
eli-darkly Dec 12, 2019
9879af0
use common 3.0.0-beta2
eli-darkly Dec 12, 2019
2f1b220
use 3.1.0-beta3, fix property name
eli-darkly Dec 12, 2019
70cc7bb
lint
eli-darkly Dec 16, 2019
b7a8b3a
use js-sdk-common 3.1.0
eli-darkly Dec 16, 2019
3c2f9bf
merge from public after release
LaunchDarklyCI Dec 16, 2019
02d4daf
Merge branch 'master' into eb/ch59034/image-loading-events
eli-darkly Dec 18, 2019
3038603
Merge pull request #232 from launchdarkly/eb/ch59034/image-loading-ev…
eli-darkly Dec 18, 2019
b744406
use js-sdk-common 3.1.1 for event payload ID fix
eli-darkly Jan 15, 2020
3ca7119
Merge pull request #234 from launchdarkly/eb/ch61092/commonsdk-fix
eli-darkly Jan 15, 2020
448e351
merge from public after release
LaunchDarklyCI Jan 16, 2020
5e22e76
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
eli-darkly Jan 27, 2020
152a246
merge from public after release
LaunchDarklyCI Jan 27, 2020
e13c33b
use js-sdk-common 3.1.2 and loosen our other dependency
eli-darkly Feb 1, 2020
7041236
Merge pull request #235 from launchdarkly/eb/ch63559/deps
eli-darkly Feb 5, 2020
8c21b80
merge from public after release
LaunchDarklyCI Feb 6, 2020
cad066a
fix license
eli-darkly Feb 8, 2020
018d52c
Merge pull request #236 from launchdarkly/eb/ch64906/license
eli-darkly Feb 8, 2020
6ce9e2d
use js-sdk-common 3.2.0-beta1
eli-darkly Feb 11, 2020
b82005f
SDK name should be js-client-sdk
eli-darkly Feb 11, 2020
fe82c4e
Merge branch 'diagnostic-events' into eb/ch57741/diagnostic-events
eli-darkly Feb 11, 2020
1e7d16a
misc fixes
eli-darkly Feb 12, 2020
105d0be
use js-sdk-common 3.2.0
eli-darkly Feb 12, 2020
b12d0c5
use js-sdk-common 3.2.0
eli-darkly Feb 12, 2020
914cad2
Merge pull request #233 from launchdarkly/eb/ch57741/diagnostic-events
eli-darkly Feb 12, 2020
7520610
standardize linting
eli-darkly Feb 13, 2020
be211de
use js-sdk-common 3.2.1
eli-darkly Feb 13, 2020
94d761a
Merge pull request #237 from launchdarkly/eb/ch65303/standardize-linting
eli-darkly Feb 13, 2020
3000dac
use js-sdk-common 3.2.2
eli-darkly Feb 14, 2020
deaed37
update package-lock
eli-darkly Feb 14, 2020
4cd5e06
merge from public after release
LaunchDarklyCI Feb 14, 2020
2791ab9
update js-sdk-common dependency for initialization error bugfix
eli-darkly Mar 7, 2020
90fc750
merge from public after release
LaunchDarklyCI Mar 7, 2020
39a9cee
update js-sdk-common for content type bugfix; update some dev depende…
eli-darkly Mar 18, 2020
13d9565
remove unsafe usage of hasOwnProperty
eli-darkly Mar 18, 2020
8b0f1cd
Merge pull request #238 from launchdarkly/eb/ch69815/content-type
eli-darkly Mar 18, 2020
387fe5b
use js-sdk-common 3.2.5
eli-darkly Mar 18, 2020
110e553
Merge pull request #239 from launchdarkly/eb/ch69855/has-own-property
eli-darkly Mar 18, 2020
47acc4f
merge from public after release
LaunchDarklyCI Mar 18, 2020
3d54a43
resolve security vulnerability in acorn dependency (#240)
bwoskow-ld Mar 25, 2020
47a85d2
update js-sdk-common to get console logging IE bugfix
eli-darkly Mar 31, 2020
467fece
Merge pull request #241 from launchdarkly/eb/ch781507/no-console
eli-darkly Mar 31, 2020
8f7ee53
merge from public after release
LaunchDarklyCI Apr 1, 2020
4e9b863
update js-sdk-common for duplicate diagnostic event fix
eli-darkly May 1, 2020
d03a0c5
Merge pull request #242 from launchdarkly/eb/ch75557/extra-diagnostics
eli-darkly May 1, 2020
a2eac3b
merge from public after release
LaunchDarklyCI May 1, 2020
8de49fe
update js-sdk-common for TS decl fix, improve TS compilation test (#243)
eli-darkly May 13, 2020
1805dec
merge from public after release
LaunchDarklyCI May 13, 2020
d5af643
bump to 3.2.9 to get startsWith fix (#244)
bwoskow-ld Jul 13, 2020
cadd3bd
merge from public after release
LaunchDarklyCI Jul 13, 2020
6d7160e
add option to disable sync event flush (#245)
eli-darkly Jul 16, 2020
e45a8d4
merge from public after release
LaunchDarklyCI Jul 16, 2020
71b4eb9
Merge branch 'master' of github.com:launchdarkly/js-client-sdk
eli-darkly Aug 5, 2020
cb2758c
update js-sdk-common + some dev dependencies
eli-darkly Sep 14, 2020
637bf27
Merge pull request #246 from launchdarkly/eb/ch89575/ping-race
eli-darkly Sep 14, 2020
afd1cbf
merge from public after release
LaunchDarklyCI Sep 14, 2020
419b4a7
No longer remove non-section hash in substring and regex matching
apache-hb Oct 16, 2020
1369644
linting
eli-darkly Oct 19, 2020
ca91691
the linting target to run in CI is "lint:all", not "lint"
eli-darkly Oct 19, 2020
953acbb
Merge pull request #248 from launchdarkly/eb/ch88476/lint
eli-darkly Oct 19, 2020
a2117ef
merge from public after release
LaunchDarklyCI Oct 19, 2020
93d4278
new js-common-sdk version (#249)
bwoskow-ld Nov 17, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update method description
  • Loading branch information
eli-darkly committed Apr 17, 2019
commit 96f2e6d76ce118d44ac9f02e3abbb6db6a1259fb
4 changes: 3 additions & 1 deletion packages/ldclient-js-common/typings.d.ts
Original file line number Diff line number Diff line change
@@ -566,7 +566,9 @@ declare module 'ldclient-js-common' {
* @param data
* Additional information to associate with the event.
* @param metricValue
* An optional numeric value that can be used in analytics.
* A numeric value to signify the value used by the LaunchDarkly experimentation feature
* in numeric custom metrics. Can be omitted if this event is used by only non-numeric
* metrics. This field will also be returned as part of the custom event for Data Export.
*/
track(key: string, data?: any, metricValue?: number): void;