bug(turndown): no browser support

[maxpatiiuk]

Current behaviour

While original turndown includes builds for the browser, @joplin/turndown only includes a single build:

And unlike the original turndown, @joplin/turndown has const css = require('css'); import, which in turn imports fs:

https://github.com/reworkcss/css/blob/master/lib/stringify/source-map-support.js#L9

That causes an error in Webpack when trying to build a project that uses @joplin/turndown:

ERROR in ./node_modules/@joplin/turndown/node_modules/css/lib/stringify/source-map-support.js 9:9-22
Module not found: Error: Can't resolve 'fs' in '/Users/maxpatiiuk/site/javascript/text-hoarder/node_modules/@joplin/turndown/node_modules/css/lib/stringify'

The same goes for "path" and "url" node core modules

Expected behaviour

Could you please publish the browser builds like the original library did?

---

A workaround for now involves adding this to my webpack config:

    resolve: {
      fallback: {
        fs: false,
        path: false,
      },
    }

and things seem to work fine, but doesn't meant it will keep working in the future...

Thanks

[personalizedrefrigerator]

Looking at the code tab on NPM, it seems that the published version of @joplin/turndown uses css and not @adobe/css-tools:

'use strict';

const css = require('css');

function extend (destination) {
  for (var i = 1; i < arguments.length; i++) {
    var source = arguments[i];
    for (var key in source) {

This difference is likely related to Joplin's release cycle.

@adobe/css-tools is a fork of the css package that should have browser support. See this commit and this pull request for additional details.

[maxpatiiuk]

That's great news - looking forward to the new release!

[github-actions]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

[github-actions]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, feel free to create a new issue with up-to-date information.