Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to other emoji vendor #551

Closed
2 tasks done
sunkhaskasis opened this issue Feb 21, 2023 · 3 comments · Fixed by #554
Closed
2 tasks done

Migrate to other emoji vendor #551

sunkhaskasis opened this issue Feb 21, 2023 · 3 comments · Fixed by #554
Labels
enhancement New feature or request

Comments

@sunkhaskasis
Copy link
Contributor

sunkhaskasis commented Feb 21, 2023

Checklist

Write your feature request here

In case you've not heard, the fate of Twemoji is rather uncertain for the near future:
twitter/twemoji#570

TL;DR: Many people responsible for the project were laid off and nobody knows what's going to happen to it now. The Unicode 15.0 update was supposed to be dispatched sometime around last year, but wasn't because of the aforementioned reasons.

If Twemoji is not going to receive new updates, it might be a good idea to choose a different emoji vendor. One option I've explored was Google Noto Color Emoji, another open-source emoji project available here:
https://github.com/googlefonts/noto-emoji

It receives regular updates and is compliant to the Unicode 15.0 standard. One major problem it has, however, is the lack of pre-made flag emoji which are available in Twemoji.

Of course, this is far from being a priority and Noto isn't the only open-source emoji vendor, but with Unicode being annually updated, Twitch Downloader would benefit from migrating as to not miss out on the Unicode updates.

@sunkhaskasis sunkhaskasis added the enhancement New feature or request label Feb 21, 2023
@sunkhaskasis sunkhaskasis changed the title Migrate to another emoji vendor Migrate to other emoji vendor Feb 21, 2023
@sunkhaskasis
Copy link
Contributor Author

A little update: I've messed around with it and have a small proof of work:
image

As you can see, Noto emoji do work well, but many of them would have to be checked for having "FE0F" in the filename to render properly.

@ScrubN
Copy link
Collaborator

ScrubN commented Feb 21, 2023

but many of them would have to be checked for having "FE0F" in the filename to render properly.

This should have been fixed in #547. Apparently String.StartsWith() and Span<T>.StartsWith() don't treat emojis the same which is why the FE0F (and #548) issues appeared

@ScrubN
Copy link
Collaborator

ScrubN commented Feb 21, 2023

Also I'm not opposed to switching to the Noto color emojis. It looks like we should be able to reliably fetch the zip at runtime too instead of embedding it which means making the application file size 8MB smaller. Also by not attributing twemoji in the readme we've been violating the license

@ScrubN ScrubN linked a pull request Feb 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants