Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum value false doesn't render #84

Open
zbodor-gs opened this issue Feb 4, 2020 · 1 comment
Open

Enum value false doesn't render #84

zbodor-gs opened this issue Feb 4, 2020 · 1 comment

Comments

@zbodor-gs
Copy link

zbodor-gs commented Feb 4, 2020

Hi,
I guess because of an old Handlebars bug (handlebars-lang/handlebars.js#827) false enum values (and thus 'constant' values too) don't render properly: they result in an empty string.

For example

{
  "type": "object",
  "properties": {
    "testTrue": {
      "type": "boolean",
      "enum": [ true ]
    },
    "testFalse": {
      "type": "boolean",
      "enum": [ false ]
    }
  }
}

results in

image

Is it possible to update the underlying handlebars lib to a newer version to fix this bug?

Thanks,
Zoli

(Possible workarounds until then: https://stackoverflow.com/questions/17664323/handlebars-doesnt-render-boolean-variables-when-false)

@zbodor-gs zbodor-gs changed the title enum value false doesn't render Enum value false doesn't render Feb 6, 2020
@yanick
Copy link
Collaborator

yanick commented Feb 6, 2020

Hi! Can you submit a PR with the change? I don't have a lot of tuits to work on this project, but I should be at least be able to merge and publish PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants