Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings set fails to set lbryum_servers (CLI only) #2213

Closed
10 tasks
tzarebczan opened this issue Jun 6, 2019 · 2 comments
Closed
10 tasks

settings set fails to set lbryum_servers (CLI only) #2213

tzarebczan opened this issue Jun 6, 2019 · 2 comments
Labels
type: bug Existing functionality is wrong or broken

Comments

@tzarebczan
Copy link
Contributor

tzarebczan commented Jun 6, 2019

The Issue

Work via Json + passing list. Might be a good time to rename it to wallet_servers too.

C:\Users\thoma\Desktop>lbrynet settings set lbryum_servers ['lbryumx1.lbry.com:50001']
{
  "lbryum_servers": []
}

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

Internal Use

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
@tzarebczan tzarebczan added the type: bug Existing functionality is wrong or broken label Jun 6, 2019
@tzarebczan tzarebczan changed the title settings set fails to set lbryum_servers settings set fails to set lbryum_servers (CLI only) Jun 6, 2019
@eukreign
Copy link
Member

eukreign commented Jun 6, 2019

This does work via lbrynet start --lbryum_servers= and with settings_set when done via JSON-RPC. It's only broken via CLI directly. I think this is very low priority issue (since it works in the most common cases).

@eukreign
Copy link
Member

eukreign commented Dec 30, 2019

fixed in #2698

make sure to put single quotes around the JSON string and use double quotes around strings inside of the JSON:

lbrynet settings set lbryum_servers '["lbryumx1.lbry.com:50001"]'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Existing functionality is wrong or broken
Projects
None yet
Development

No branches or pull requests

2 participants