consider default dustrelayfee when generating transactions

[tzarebczan]

Per lbryio/lbrycrd#307 (comment), the min vout value will be 3000 dewies in the next lbrycrd release (this was later updated to 1000 dewies). Today, torba produces transactions with very small vouts that may not get processed by all miners, and thus, stuck in the mempool.

When creating txs, torba should consider this min amount to ensure there's no vout that's lower than it.

[tzarebczan]

These are happening in the wild now - we must not have all our lbrycrd servers configured with the legacy default min fee (this was just a workaround as miners may not accept it anyway).

User(3363131) Desktop Error: "(1, 'the transaction was rejected by network rules.\\n\\ndust (code 65)\\n[0100000001e15aa26d01e24dde316dce3a528d5f378e5128004f38f1006abc0b6133c362f3000000006a47304402201ede1c76a085f53b4cbf286da3c6cf33dae6f9334e21956a52d0e19ce0e26f3e022025fb4634d3856d4b40eafe2d3a791bd7ca3b744dc3bdb6d3bce56326e692f501012102285cf051e132f5f4efe8d23594b3370884d235b6830b90ddf7b84ea9fe43b8f3ffffffff026400000000000000fdc603b52157617463682d2d2d74726b2d2d706372642d2d317830372d6d373230702d6d6b764d850301c2fd4562b41524ec85235beaa8c26fad500764aba2aca6fb1117292fe6c2dec69e8ad9d419ccecc13df9d865af113a26f78e5bb8ad989890de0d23cd112aef9d2bf053860ad04971f8f49fcfac69c79cd78334940ab5010a9b010a30c04ba7c483d7337afcb57e4629976e4e434daed0fa9e07c090464fc2e68dbf31b2e3080f3b1370710e372e734b880f511225576174636820262674726b262670637264262631783037206d37323070206d6b762e6d703418aaf3ad482209766964656f2f6d7034323089e01a7617e0a60a48ead63a15c9cf5ed0651a776d23b812511cda17c13c82f8b9d8d80978ac758eb2e78b848f74c9bb1a044e6f6e6528a79887f3055a09088005108c0218d31b423ff09f91892a2a53657269652053746172205472656b205069636172642054656d706f7261646120312d4361504954554c4f20372a2af09f9188e29c85e29c854ac901412066696e616c65732064656c207369676c6f20585849562c20656c20616c6d6972616e746520726574697261646f204a65616e2d4c7563205069636172642c20746f646176c3ad6120616665637461646f20706f72206c612070c3a972646964612064656c2054656e69656e746520436f6d616e64616e746520446174612079206c6120646573747275636369c3b36e20646520526f6d756c75732c20656e74726120656e20656c207369677569656e746520636170c3ad74756c6f20646520737520766964612e52312a2f68747470733a2f2f737065652e63682f382f41696e536f4f73774d52464f6744557837733742376a36642e6a7065675a0573657269655a0973746172207472656b5a1673657269652073746172207472656b207069636172645a147665722073746172207472656b207069636172645a2273657269652073746172207472656b207069636172642074656d706f7261646120315a1073746172207472656b207069636172645a1d73657269652073746172207472656b20706963617264206772617469735a0b656e2065737061c3b16f6c5a09656e206c6174696e6f5a1c73746172207472656b207069636172642074656d706f7261646120315a20736572696520646520616d617a6f6e2073746172207472656b207069636172645a1e747261696c65722073657269652073746172207472656b207069636172645a25747261696c657220736572696520616d617a6f6e2073746172207472656b20706963617264620208286d7576a9147dd32d507b393932bb0c660f48fb26969be92c0788ac448d3300000000001976a9143b6827289e629bdefb5da5bf6a219eb6751c395b88ac00000000]')"

[tzarebczan]

lbry-sdk should also not allow any claims/transactions to be created with outputs lower than the dust limit (1000 sats).

[tzarebczan]

Here's an example of one being created as change by the SDK: https://explorer.lbry.com/tx/57b7eb3c7609c4af004d2bf94030909af4a29f27e413e2a272e20c9e39932d39#input-24995255

Another: https://explorer.lbry.com/tx/0a356dc0649a4b10efa9a695e617c7b6aca37f05b2c87be6f4b468bbe040fd3e#output-0

[tzarebczan]

Still happening in the wild: https://explorer.lbry.com/tx/877c1633a06b1f189aef181991e8cf0acb141984db1a00006f7e688f4331c272?address=bFQv39voFRbs95w2z7aErA4op9FAz6o8di#bFQv39voFRbs95w2z7aErA4op9FAz6o8di

[tzarebczan]

YT Sync:
ERRO[109021] Video bxFMJn1i8Us failed after 3 retries, skipping. Stack: *errors.errorString publish error: Error in daemon: (1, 'the transaction was rejected by network rules.\n\ndust (code 65)\n[010000000105aaf26123aa9c80f64ab7753af7df315b171e207ec832eed8935f5131938016010000006b48304502210089d57f190d4618086f44de12958537efcc75a39b2da774d95d40f85e7da6633802205b0b42aaf4bcf9ecfd4dcf52e978394c5f59b124ce1d05986e5e80178eecc64f0121039a3bb5d51a020ef6c38fa88621b4e3d4943c0e2c2451b775d9ea1a48c423d802ffffffff0240420f0000000000fddd0db525626974636f696e2d28627463292c2d6d61696e74656e616e742d6f752d6a616d6169732d334d980d016fe1672d4235500725c07cef8bfcf2d472d151a355bcc2f18aff8ee87bb0ef55e95353417c6807343443d8c3cd14ded486cc8cf52b31dc729a8b281d1803e9d13a845ba8f0d76448d5698bf2aa83582ac49ee3570ac8010a93010a30d7199dea6a5d00e53f16e105ea95030d4dd19f49935c3816be062b4424ce62786a2d60a0328ef38a1b17aa84140abb48121d626974636f696e2d6274632d6d61696e74656e616e742d6f752e6d703418bdc0d8542209766964656f2f6d70343230f79c35796f5d7a5757294648f288071aceae2c724ef3fa75bffd23fd58a4fd14325ad6f3bfaaf8acc0707ef7b8e00bb11a1f436f7079726967687465642028636f6e74616374207075626c69736865722928b8f9e18d065a0908800f10b808189c074240426974636f696e2028425443292c206d61696e74656e616e74206f75206a616d616973202d204c27616e616c7973652064652056696e63656e742047616e6e654aa0164465726e69c3a872652073656d61696e65206372756369616c65206465206c27616e6ec3a9652061766563206c65732064c3a9636973696f6e7320646520706f6c697469717565206d6f6ec3a97461697265206465206c6120464544206574206465206c61204243452063657474652073656d61696e652e204c6520636f75727320647520626974636f696e2074656e74652064652064c3a966656e64726520756e20737570706f727420c3a02034372e303030242c206d6169732073616e732073c3a9616e63652064652064c3a970617373656d656e742064652072c3a973697374616e63652c206c65206d61726368c3a920726573746520656e20636f7272656374696f6e2e20506f696e7420746563686e69717565204254432c204554482c20424e422026205645542e0a0af09f91be2047524f5550452050524956c38920444953434f524420e296ba2068747470733a2f2f70726f2e63727970746f6173742e66722f6c652d6772696c6c652d7061696e2f0a0af09f94b420534f4e444147452043525950544f20424f4e555320e296ba68747470733a2f2f7777772e796f75747562652e636f6d2f706f73742f55676b786166635166423250554d5f7a415f37752d6d4638666348337435764c64396e750a536920766f757320736f7568616974657a20766f74657220706f7572206c612063727970746f20626f6e7573206465206c612073656d61696e652070726f636861696e650a0a56696e63656e742047616e6e6520657374206d616e61676572206368657a2054726164696e675669657720657420696e74657276656e616e74207375722042464d20427573696e6573732e0ae296ba20547769747465722064652056696e63656e74203a2068747470733a2f2f747769747465722e636f6d2f56696e63656e7447616e6e650a0a546f757465206c27616374752063727970746f20696369203a2068747470733a2f2f63727970746f6173742e66722f616374752f0a0af09f939a20464f524d4154494f4e2044c389425554414e54532043525950544f20e296ba2068747470733a2f2f70726f2e63727970746f6173742e66722f666f726d6174696f6e2d63727970746f2d6465636f7576657274652f0af09f92b820464f524d4154494f4e2046494e414e43452044c38943454e5452414c4953c3894520e296ba2068747470733a2f2f70726f2e63727970746f6173742e66722f666f726d6174696f6e2d646566692f0af09f91be2047524f5550452050524956c38920444953434f524420e296ba2068747470733a2f2f70726f2e63727970746f6173742e66722f6c652d6772696c6c652d7061696e2f0af09f92b02042494e414e434520282d3130252046524149532920e296ba2068747470733a2f2f63727970746f6173742e66722f676f2d62696e616e63652d31302f0af09f928e205357495353424f524720285449434b4554204741474e414e5420322d313030e282ac20454e204254432920e296ba2068747470733a2f2f63727970746f6173742e66722f676f2d7377697373626f72672f0ae29abd20534f5241524520284a455520444520464f4f5420424c4f434b434841494e2920e296ba2068747470733a2f2f63727970746f6173742e66722f676f2d736f726172652f0af09f979defb88f204c45444745522028434f464652452d464f52542043525950544f2920e296ba2068747470733a2f2f63727970746f6173742e66722f676f2d6c65646765722f0ae29b8fefb88f204645454c204d494e494e4720282d3525204156454320434f4445203a20544f4153542920e296ba2068747470733a2f2f63727970746f6173742e66722f676f2d6665656c2d6d696e696e672f0a0a30303a3030203a20496e74726f64756374696f6e0a30343a3139203a20426974636f696e2028425443290a31303a3033203a20457468657265756d2028455448290a31323a3437203a2042696e616e636520436f696e2028424e42290a31333a3230203a205665436861696e2028564554290a31343a3434203a20436f6e636c7573696f6e200a0a426f6e6e6520c3a9636f7574652c206574206e2768c3a9736974657a2070617320c3a0206e6f75732073756976726520737572206c65732072c3a9736561757820210a0af09f8c8e2053697465203a2068747470733a2f2f63727970746f6173742e66722f0af09f90a62054776974746572203a2068747470733a2f2f747769747465722e636f6d2f63727970746f617374626c6f670af09f93982046616365626f6f6b203a2068747470733a2f2f66616365626f6f6b2e636f6d2f63727970746f6173740ae29c88efb88f2054656c656772616d203a2068747470733a2f2f742e6d652f63727970746f6173745f66720af09f8eae20547769746368203a2068747470733a2f2f7777772e7477697463682e74762f63727970746f61737474760af09f92bc204c696e6b6564496e203a2068747470733a2f2f7777772e6c696e6b6564696e2e636f6d2f636f6d70616e792f63727970746f6173742f3f6f726967696e616c537562646f6d61696e3d66720af09f93b820496e7374616772616d203a2068747470733a2f2f7777772e696e7374616772616d2e636f6d2f63727970746f617374626c6f672f0af09f8eb52054696b20546f6b203a2068747470733a2f2f74696b746f6b2e636f6d2f4063727970746f617374626c6f670a0af09f92a12051756920736f6d6d65732d6e6f7573203f0a0a43727970746f61737420657374206c65207369746520c3a964756361746966206672616e636f70686f6e652064652072c3a966c3a972656e636520737572206c6520426974636f696e2c206c6120626c6f636b636861696e206574206c65732063727970746f2d6d6f6e6e616965732e20566f757320792074726f75766572657a20647520636f6e74656e7520677261747569742c206164617074c3a9206175782064c3a9627574616e747320636f6d6d652061757820636f6e6669726dc3a9732c2065742061637475616c6973c3a920746f7573206c6573206a6f7572732e204e6f747265206f626a6563746966203f2052656e6472652063657420756e69766572732061636365737369626c6520617520706c7573206772616e64206e6f6d6272652e0a0af09f93a720636f6e746163744063727970746f6173742e66720a0a2342544320234554482023424e42202346544d2023416e616c7973652023426974636f696e2023457468657265756d20234574686572202342696e616e6365436f696e202356696e63656e7447616e6e65202342696e616e6365202346616e746f6d202343727970746f6d6f6e6e616965202343727970746f202354726164696e672023465220234672616e63616973202350726564696374696f6e2023507269782023436f696e20234672656e6368202350756d70202344756d7020234d6f6e6e6169652023416e616c797365546563686e697175652023546563686e697175652023426c6f636b636861696e0a0ae29aa0efb88f20444953434c41494d45520a546f7573206c65732061766973206578706f73c3a9732064616e7320636574746520766964c3a96f206e6520736f6e742071756520646573206176697320706572736f6e6e656c73206574206e6520636f6e7374697475656e7420656e20617563756e206361732064657320636f6e7365696c7320656e20696e76657374697373656d656e742e20566f757320c3aa746573206c61207365756c6520706572736f6e6e65206170746520c3a0207072656e647265206c65732064c3a9636973696f6e7320656e2063652071756920636f6e6365726e65206ce280997574690a2e2e2e0a68747470733a2f2f7777772e796f75747562652e636f6d2f77617463683f763d6278464d4a6e316938557352292a2768747470733a2f2f7468756d626e61696c732e6c6272792e636f6d2f6278464d4a6e31693855735a0a626c6f636b636861696e5a0965636f6e6f6d6963735a07616e616c7973655a0762696e616e63655a0b62696e616e6365636f696e5a07626974636f696e5a03626e625a036274635a04636f696e5a0663727970746f5a0d63727970746f6d6f6e6e6169655a0464756d705a036574685a0565746865725a08657468657265756d5a0666616e746f6d5a086672616e636169735a066672656e63685a0366746d5a076d6f6e6e6169655a0a70726564696374696f6e5a04707269785a0470756d705a09746563686e697175655a0774726164696e675a0c76696e63656e7467616e6e65620208306d7576a914011a4abad40c0ebae921f09bf412f7985743d89b88ac49000000000000001976a914813da0c626a5509eb63ab640eec7aca112c3079d88ac00000000]')
/home/travis/gopath/pkg/mod/github.com/lbryio/lbry.go/v2@v2.7.2-0.20210824154606-3e18b74da08b/extras/jsonrpc/daemon.go:117 (0xf53505

[tzarebczan]

Happened to a VIP creator when updating a claim: