fix #36 #175
Merged
fix #36 #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you upload screenshots ? |
lc-soft
requested changes
Aug 14, 2019
|
I'm sorry that I don't know much about the code structure of this project. |
|
能用中文就用中文，整英文反而增加沟通成本。 |
lc-soft
requested changes
Aug 15, 2019
src/ime.c
Outdated
| @@ -270,6 +270,13 @@ void LCUI_InitIME(void) | |||
| #endif | |||
| } | |||
|
|
|||
| void LCUIIME_SetCaret(LCUI_Pos pos) | |||
| { | |||
| if (self.ime->handler.setcaret == NULL) | |||
There was a problem hiding this comment.
只是处理 if 条件成立的情况，那可以写成：
if (self.ime->handler.setcaret) {
self.ime->handler.setcaret(pos);
}
src/platform/windows/windows_ime.c
Outdated
| HWND hwnd = GetActiveWindow(); | ||
| HIMC hIMC = ImmGetContext(hwnd); | ||
| if (hIMC) { | ||
| COMPOSITIONFORM Composition; |
src/ime.c
Outdated
| @@ -270,6 +270,13 @@ void LCUI_InitIME(void) | |||
| #endif | |||
| } | |||
|
|
|||
| void LCUIIME_SetCaret(LCUI_Pos pos) | |||
There was a problem hiding this comment.
LCUI_Pos 是以前定义数据类型，现在已经尽量不用它了，请使用 x y 两个变量代替
src/platform/windows/windows_ime.c
Outdated
| static void IME_SetCaret(LCUI_Pos pos) | ||
| { | ||
| HWND hwnd = GetActiveWindow(); | ||
| HIMC hIMC = ImmGetContext(hwnd); |
|
(PR updated) |
|
@1354092549 效果图发一下，最好是 gif 屏幕录像，windows 系统可以用 ScreenToGif 录制。 |
|
|
现在用的是 clang-format |
clang-format貌似不包括 命名检查？ |
@1354092549 是的，只是个格式化工具，没检查功能。 |
lc-soft
pushed a commit
that referenced
this pull request
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor