refactor: pass the actual tag to onclosetag

BREAKING CHANGE:

Sax was only passing the tag name. We pass the whole object.

lib/saxes.js

@@ -1856,7 +1856,7 @@ ${JSON.stringify(this.tagName)}.`);
     let s = this.tags.length;
     while (s-- > t) {
       const tag = this.tag = tags.pop();
-      this.emitNode("onclosetag", tag.name);
+      this.emitNode("onclosetag", tag);
     }
     if (t === 0) {
       this.inRoot = false;

test/attribute-name.js

@@ -27,7 +27,23 @@ require(".").test({
     ],
     [
       "closetag",
-      "root",
+      {
+        name: "root",
+        prefix: "",
+        local: "root",
+        uri: "",
+        attributes: {
+          length: {
+            name: "length",
+            value: "12345",
+            prefix: "",
+            local: "length",
+            uri: "",
+          },
+        },
+        ns: {},
+        isSelfClosing: false,
+      },
     ],
   ],
   opt: {

test/attribute-no-space.js

@@ -8,7 +8,7 @@ require(".").test({
     ["opentagstart", { name: "root", attributes: {} }],
     ["error", "undefined:1:20: no whitespace between attributes."],
     ["opentag", { name: "root", attributes: { attr1: "first", attr2: "second" }, isSelfClosing: true }],
-    ["closetag", "root"],
+    ["closetag", { name: "root", attributes: { attr1: "first", attr2: "second" }, isSelfClosing: true }],
   ],
   opt: { },
 });
@@ -20,7 +20,7 @@ require(".").test({
   expect: [
     ["opentagstart", { name: "root", attributes: {} }],
     ["opentag", { name: "root", attributes: { attr1: "first", attr2: "second" }, isSelfClosing: true }],
-    ["closetag", "root"],
+    ["closetag", { name: "root", attributes: { attr1: "first", attr2: "second" }, isSelfClosing: true }],
   ],
   opt: { },
 });
@@ -32,7 +32,7 @@ require(".").test({
   expect: [
     ["opentagstart", { name: "root", attributes: {} }],
     ["opentag", { name: "root", attributes: { attr1: "first", attr2: "second" }, isSelfClosing: true }],
-    ["closetag", "root"],
+    ["closetag", { name: "root", attributes: { attr1: "first", attr2: "second" }, isSelfClosing: true }],
   ],
   opt: { },
 });
@@ -44,7 +44,7 @@ require(".").test({
   expect: [
     ["opentagstart", { name: "root", attributes: {} }],
     ["opentag", { name: "root", attributes: { attr1: "first", attr2: "second" }, isSelfClosing: true }],
-    ["closetag", "root"],
+    ["closetag", { name: "root", attributes: { attr1: "first", attr2: "second" }, isSelfClosing: true }],
   ],
   opt: { },
 });

test/attribute-unquoted.js

@@ -22,7 +22,23 @@ require(".").test({
       uri: "",
       isSelfClosing: false,
     }],
-    ["closetag", "root"],
+    ["closetag", {
+      name: "root",
+      attributes: {
+        length: {
+          name: "length",
+          value: "12345",
+          prefix: "",
+          local: "length",
+          uri: "",
+        },
+      },
+      ns: {},
+      prefix: "",
+      local: "root",
+      uri: "",
+      isSelfClosing: false,
+    }],
     ["end", undefined],
     ["ready", undefined],
   ],

test/bad-entities.js

@@ -8,7 +8,7 @@ require(".").test({
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["error", "undefined:1:5: malformed character entity."],
     ["text", "&;"],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
 });
 
@@ -20,7 +20,7 @@ require(".").test({
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["error", "undefined:1:6: malformed character entity."],
     ["text", "&#;"],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
 });
 
@@ -32,6 +32,6 @@ require(".").test({
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["error", "undefined:1:7: malformed character entity."],
     ["text", "&#x;"],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
 });

test/bom.js

@@ -7,7 +7,7 @@ require(".").test({
   expect: [
     ["opentagstart", { name: "P", attributes: {} }],
     ["opentag", { name: "P", attributes: {}, isSelfClosing: false }],
-    ["closetag", "P"],
+    ["closetag", { name: "P", attributes: {}, isSelfClosing: false }],
   ],
 });
 
@@ -19,7 +19,7 @@ require(".").test({
     ["opentagstart", { name: "P", attributes: {} }],
     ["opentag", { name: "P", attributes: { BOM: "\uFEFF" }, isSelfClosing: false }],
     ["text", "\uFEFFStarts and ends with BOM\uFEFF"],
-    ["closetag", "P"],
+    ["closetag", { name: "P", attributes: { BOM: "\uFEFF" }, isSelfClosing: false }],
   ],
 });
 
@@ -32,7 +32,7 @@ require(".").test({
     ["text", "\uFEFF"],
     ["opentagstart", { name: "P", attributes: {} }],
     ["opentag", { name: "P", attributes: {}, isSelfClosing: false }],
-    ["closetag", "P"],
+    ["closetag", { name: "P", attributes: {}, isSelfClosing: false }],
   ],
 });
 
@@ -45,6 +45,6 @@ require(".").test({
     ["text", "\uFEFF"],
     ["opentagstart", { name: "P", attributes: {} }],
     ["opentag", { name: "P", attributes: {}, isSelfClosing: false }],
-    ["closetag", "P"],
+    ["closetag", { name: "P", attributes: {}, isSelfClosing: false }],
   ],
 });

test/cdata-chunked.js

@@ -6,7 +6,7 @@ require(".").test({
     ["opentagstart", { name: "r", attributes: {} }],
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["cdata", " this is character data  "],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
   fn(parser) {
     parser.write("<r><![CDATA[ this is ").write("character data  ")

test/cdata-end-split.js

@@ -6,7 +6,7 @@ require(".").test({
     ["opentagstart", { name: "r", attributes: {} }],
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["cdata", " this is "],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
   fn(parser) {
     parser.write("<r><![CDATA[ this is ]")

test/cdata-fake-end.js

@@ -6,7 +6,7 @@ require(".").test({
     ["opentagstart", { name: "r", attributes: {} }],
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["cdata", "[[[[[[[[]]]]]]]]"],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
   fn(parser) {
     const x = "<r><![CDATA[[[[[[[[[]]]]]]]]]]></r>";
@@ -23,7 +23,7 @@ require(".").test({
     ["opentagstart", { name: "r", attributes: {} }],
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["cdata", "[[[[[[[[]]]]]]]]"],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
   xml: "<r><![CDATA[[[[[[[[[]]]]]]]]]]></r>",
 });

test/cdata-multiple.js

@@ -7,7 +7,7 @@ require(".").test({
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["cdata", " this is "],
     ["cdata", "character data  "],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
   fn(parser) {
     parser.write("<r><![CDATA[ this is ]]>").write("<![CDA")

test/cdata.js

@@ -8,6 +8,6 @@ require(".").test({
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["cdata", " this is character data  "],
     ["cdata", ""],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
 });

test/comment.js

@@ -8,6 +8,6 @@ require(".").test({
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["comment", "foo"],
     ["comment", ""],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
 });

test/cyrillic.js

@@ -7,6 +7,6 @@ require(".").test({
     ["opentagstart", { name: "Р", attributes: {} }],
     ["opentag", { name: "Р", attributes: {}, isSelfClosing: false }],
     ["text", "тест"],
-    ["closetag", "Р"],
+    ["closetag", { name: "Р", attributes: {}, isSelfClosing: false }],
   ],
 });

test/duplicate-attribute.js

@@ -14,7 +14,11 @@ require(".").test({
       attributes: { id: "there" },
       isSelfClosing: false,
     }],
-    ["closetag", "span"],
+    ["closetag", {
+      name: "span",
+      attributes: { id: "there" },
+      isSelfClosing: false,
+    }],
   ],
   opt: {},
 });

test/emoji.js

@@ -8,7 +8,7 @@ require(".").test({
     ["opentagstart", { name: "a", attributes: {} }],
     ["opentag", { name: "a", attributes: {}, isSelfClosing: false }],
     ["text", "\ud83d\udd25"],
-    ["closetag", "a"],
+    ["closetag", { name: "a", attributes: {}, isSelfClosing: false }],
   ],
   opt: {},
 });

test/entities.js

@@ -7,6 +7,6 @@ require(".").test({
     ["opentagstart", { name: "r", attributes: {} }],
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["text", "& < > >"],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
 });

test/entity-nan.js

@@ -8,6 +8,6 @@ require(".").test({
     ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
     ["error", "undefined:1:9: malformed character entity."],
     ["text", "&#NaN;"],
-    ["closetag", "r"],
+    ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
 });

test/issue-23.js

@@ -20,29 +20,29 @@ require(".").test({
     ["opentagstart", { name: "bodyCrc", attributes: {} }],
     ["opentag", { name: "bodyCrc", attributes: {}, isSelfClosing: false }],
     ["text", "653724009"],
-    ["closetag", "bodyCrc"],
+    ["closetag", { name: "bodyCrc", attributes: {}, isSelfClosing: false }],
     ["opentagstart", { name: "column", attributes: {} }],
     ["opentag", { name: "column", attributes: {}, isSelfClosing: false }],
     ["text", "-1"],
-    ["closetag", "column"],
+    ["closetag", { name: "column", attributes: {}, isSelfClosing: false }],
     ["opentagstart", { name: "id", attributes: {} }],
     ["opentag", { name: "id", attributes: {}, isSelfClosing: false }],
     ["text", "01pG0000002KoSUIA0"],
-    ["closetag", "id"],
+    ["closetag", { name: "id", attributes: {}, isSelfClosing: false }],
     ["opentagstart", { name: "line", attributes: {} }],
     ["opentag", { name: "line", attributes: {}, isSelfClosing: false }],
     ["text", "-1"],
-    ["closetag", "line"],
+    ["closetag", { name: "line", attributes: {}, isSelfClosing: false }],
     ["opentagstart", { name: "name", attributes: {} }],
     ["opentag", { name: "name", attributes: {}, isSelfClosing: false }],
     ["text", "CalendarController"],
-    ["closetag", "name"],
+    ["closetag", { name: "name", attributes: {}, isSelfClosing: false }],
     ["opentagstart", { name: "success", attributes: {} }],
     ["opentag", { name: "success", attributes: {}, isSelfClosing: false }],
     ["text", "true"],
-    ["closetag", "success"],
-    ["closetag", "result"],
-    ["closetag", "compileClassesResponse"],
+    ["closetag", { name: "success", attributes: {}, isSelfClosing: false }],
+    ["closetag", { name: "result", attributes: {}, isSelfClosing: false }],
+    ["closetag", { name: "compileClassesResponse", attributes: {}, isSelfClosing: false }],
   ],
   opt: {},
 });

test/issue-33.js

@@ -17,9 +17,9 @@ require(".").test({
     ["text", "\n"],
     ["opentagstart", { name: "data", attributes: {} }],
     ["opentag", { name: "data", attributes: {}, isSelfClosing: true }],
-    ["closetag", "data"],
+    ["closetag", { name: "data", attributes: {}, isSelfClosing: true }],
     ["text", "\n"],
-    ["closetag", "xml"],
+    ["closetag", { name: "xml", attributes: {}, isSelfClosing: false }],
   ],
   opt: {},
 });

test/issue-35.js

@@ -8,7 +8,7 @@ require(".").test({
     ["opentagstart", { name: "xml", attributes: {} }],
     ["opentag", { name: "xml", attributes: {}, isSelfClosing: false }],
     ["text", "\r\r\n"],
-    ["closetag", "xml"],
+    ["closetag", { name: "xml", attributes: {}, isSelfClosing: false }],
   ],
   opt: {},
 });

test/issue-47.js

@@ -7,7 +7,7 @@ require(".").test({
   expect: [
     ["opentagstart", { name: "a", attributes: {} }],
     ["opentag", { name: "a", attributes: { href: "query.svc?x=1&y=2&z=3" }, isSelfClosing: true }],
-    ["closetag", "a"],
+    ["closetag", { name: "a", attributes: { href: "query.svc?x=1&y=2&z=3" }, isSelfClosing: true }],
   ],
   opt: {},
 });

test/issue-84.js

@@ -9,7 +9,7 @@ require(".").test({
     ["opentag", { name: "xml", attributes: {}, isSelfClosing: false }],
     ["processinginstruction", { target: "has", body: "unbalanced \"quotes" }],
     ["text", "body"],
-    ["closetag", "xml"],
+    ["closetag", { name: "xml", attributes: {}, isSelfClosing: false }],
   ],
   opt: {},
 });

test/issue-86.js

@@ -25,7 +25,11 @@ require(".").test({
     ],
     [
       "closetag",
-      "root",
+      {
+        name: "root",
+        attributes: {},
+        isSelfClosing: false,
+      },
     ],
     [
       "error",

test/opentagstart.js

@@ -34,7 +34,23 @@ require(".").test({
     ],
     [
       "closetag",
-      "root",
+      {
+        name: "root",
+        prefix: "",
+        local: "root",
+        uri: "",
+        attributes: {
+          length: {
+            name: "length",
+            value: "12345",
+            prefix: "",
+            local: "length",
+            uri: "",
+          },
+        },
+        ns: {},
+        isSelfClosing: false,
+      },
     ],
   ],
   opt: {
@@ -65,7 +81,13 @@ require(".").test({
     ],
     [
       "closetag",
-      "root",
+      {
+        name: "root",
+        attributes: {
+          length: "12345",
+        },
+        isSelfClosing: false,
+      },
     ],
   ],
 });