Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blip-o-matic don't react on changing droplist "generator" #233

Closed
Shamancs opened this issue Sep 24, 2023 · 3 comments · Fixed by #236
Closed

blip-o-matic don't react on changing droplist "generator" #233

Shamancs opened this issue Sep 24, 2023 · 3 comments · Fixed by #236
Labels

Comments

@Shamancs
Copy link

I try it in Chrome.
When I change droplist "generator" is nothing changed in sound-diagram and game data, so I can't create other beep models (
Example on pictures below:
2
1

@nashalexander
Copy link
Contributor

It appears you need to create a new sound file with the + button for the generator to work. Not sure what the design choices are here, but I could see adding a small generate button next to the drop down to be helpful. That way you wouldn't overwrite your current sound on accident, but could regenerate if desired.

@le-doux
Copy link
Owner

le-doux commented Apr 26, 2024

@nashalexander is right that is working as designed although I agree it’s not intuitive - I like the solution of adding a regenerate button and I’ll merge that PR soon! thank you both!

@le-doux
Copy link
Owner

le-doux commented Apr 27, 2024

closing since @nashalexander's change addressing has been merged into the branch for the next version :)

@le-doux le-doux closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants