Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regenerate button for blips #236

Merged

Conversation

nashalexander
Copy link
Contributor

@nashalexander nashalexander commented Nov 7, 2023

Description

Closes #233

Adds a regenerate button to the blip tool. This removes the need to create new files just to generate new blips, improving usability.

Notes

  • Loop icon used as the regenerate button
  • Regenerating a blip does not modify its name
  • New file name generation still works as it did before, with new files having the name "generator #" with incrementing numbers

Screenshots

Screen Shot 2023-11-06 at 9 42 57 PM

@nashalexander nashalexander changed the title Added regenerate button for blips Add regenerate button for blips Nov 7, 2023
* Regenerate blips without creating a new one
* Regenerating a blip does not modify its name
@nashalexander nashalexander force-pushed the add_regenerate_blip_button branch from 512019f to b1ebca3 Compare November 7, 2023 02:28
@nashalexander
Copy link
Contributor Author

Hello, just following up on this.

I can remove this PR if new features are not desired, or modify if modifications are required.

Copy link
Owner

@le-doux le-doux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @nashalexander thanks for the PR! sorry I'm just getting to this now - last year was an extremely hectic time in my personal life so I'm way behind on checking github issues. anyway, I think this is a great addition - I'll include it in the next bitsy update, which should be pretty soon! thanks again for contributing!

@nashalexander
Copy link
Contributor Author

No worries, thanks for the approval!

@le-doux le-doux changed the base branch from main to version-8-12 April 27, 2024 20:29
@le-doux le-doux merged commit 0085952 into le-doux:version-8-12 Apr 27, 2024
1 check passed
le-doux added a commit that referenced this pull request May 3, 2024
* Add regenerate button for blips (#236)

* Regenerate blips without creating a new one
* Regenerating a blip does not modify its name

* Write Guide for lockedDoor.md (#257)

* Write Guide for lockedDoor.md

Write step by step guide with images explaining how to create a locked door

* Fix build crash for lockedDoor.md

The format for one of the images caused the build to crash. Attempt to fix it.

* Fix another build crash in lockedDoor.md

The crash seems to be related to the images placed side-by-side, but I'm not entirely sure. Hopefully this fixes it.

* Add new image in lockedDoor.md

I combined the two separate images, so hopefully npm doesn't get upset and crash this time.

* Remove image in lockedDoor.md

I'm not sure why the last image kept causing a crash. Removing it for now, and maybe someone can help me add it back later.

* Add image back to lockedDoor.md

npm crashed even without the image, so that was not the problem. Trying to rewrite the bottom of the file in case there was a hidden character causing the crash.

* Removing Step 5 in lockedDoor.md

Seeing if npm crashes without the last step written.

* Update lockedDoor.md

I'm not sure what's causing the npm crash. I'm just going to leave the file so it looks how I intended in the preview, and hopefully someone can help me fix the npm crash.

* Add closing tags to img in lockedDoor.md

* v8.12 updates

---------

Co-authored-by: Alex Nash <contact@alexnash.dev>
Co-authored-by: vaasut <vaasut1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blip-o-matic don't react on changing droplist "generator"
2 participants