Add support for passing config objects to the client #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandromoreira
approved these changes
Aug 4, 2023
|
thank you @dhruvCW have you tested using sentinel? |
Yup tested this with both sentinel and local redis setup. |
|
@leandromoreira May I ask you to push a new release with this change? 🙏🏼 This PR includes a change to the dependency constraints that makes redlock compatible with the recently-released redis-client versions 0.15.0 and 0.16.0. |
|
@franzliedke I'll do it by tomorrow sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the migration to
RedisClientinstead ofRedisthe support for passing redis configurations was broken.This PR adds the support back.