Use Monitor to make sure we call RedisClient in a thread safe way.
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RedisClient` is not thread safe. Thus we should do what `redis-rb` does and use a `Monitor` when calling the `client`.
it just makes sense IMO to use `LockError` as a base error type.
leandromoreira
approved these changes
Aug 20, 2023
|
Thank you @dhruvCW 🚀 |
|
@leandromoreira could we push a patch release with these changes soon ? We need this to be able to use |
|
will do @dhruvCW |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Monitorwhenever we callRedisClient. This is required sinceRedisClientis not thread safe, thus we should do what [redis-rb](https://github.com/redis/redis-rb/blob/master/lib/redis.rb#L161)does 🙂Derived
LockAcquisitionErrorfromLockError. This just makes sense IMO to keepLockErroras the base error type for this library.Add documentation for how to use
RedLockwith sentinel configuration.