Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: relax the assertion inside gatherAllTypesInfo #243

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix: relax the assertion inside gatherAllTypesInfo #243

merged 1 commit into from
Jul 9, 2024

Conversation

rvan-mee
Copy link
Contributor

@rvan-mee rvan-mee commented Jul 9, 2024 •
edited
Loading

No description provided.

yuri91
yuri91 requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@yuri91 yuri91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reword the commit to not be a fixup commit.
Since we already committed on master we shouldn't change the history anymore.
call it something like "fix: relax assertion in [...]"

@rvan-mee rvan-mee force-pushed the fix-collapsed-downcast branch from 463c2a9 to 791b8a7 Compare July 9, 2024 10:37
@rvan-mee rvan-mee changed the title fixup! Prevent collapsing of secondary bases used inside a hierarchy … Fix: relax the assertion inside gatherAllTypesInfo Jul 9, 2024
@yuri91 yuri91 merged commit 6bf14b4 into master Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuri91 yuri91 yuri91 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvan-mee @yuri91