Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(*): address a few porting notes in concrete categories #21790

Closed
wants to merge 3 commits into from

Conversation

Vierkantor
Copy link
Contributor

A not particularly exhaustive fix of a few porting notes in Algebra/Category, AlgebraicGeometry, AlgebraicTopology and Topology/Category.


Open in Gitpod

A not particularly exhaustive fix of a few porting notes in `Algebra/Category`, `AlgebraicGeometry`, `AlgebraicTopology` and `Topology/Category`.
@Vierkantor Vierkantor added porting-notes Mathlib3 to Mathlib4 porting notes. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

PR summary b3a30d9f62

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance {X : Compactum} : TopologicalSpace X
- instance {X : Compactum} : TopologicalSpace X.A

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (5.52, 0.01)
Current number Change Type
3602 -15 porting notes
1339 -2 erw

Current commit b3a30d9f62
Reference commit 40649a9379

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@kim-em
Copy link
Contributor

kim-em commented Feb 12, 2025

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Feb 12, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 12, 2025
A not particularly exhaustive fix of a few porting notes in `Algebra/Category`, `AlgebraicGeometry`, `AlgebraicTopology` and `Topology/Category`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 13, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(*): address a few porting notes in concrete categories [Merged by Bors] - chore(*): address a few porting notes in concrete categories Feb 13, 2025
@mathlib-bors mathlib-bors bot closed this Feb 13, 2025
@mathlib-bors mathlib-bors bot deleted the small-cat-fixes branch February 13, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants