Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make incomplete proofs more prominent #337

Open
DanielFabian opened this issue Aug 1, 2023 · 2 comments
Open

Make incomplete proofs more prominent #337

DanielFabian opened this issue Aug 1, 2023 · 2 comments

Comments

@DanielFabian
Copy link

I've been working through mathematics in lean and I've found on the same page multiple incomplete proofs that I just didn't notice.

As it stands it puts a red squiggly under the by for a the tactics block.

It's pretty small and somewhat easy to miss.

How hard would it be to add something more prominent like the yellow squiggly when a proof uses sorry?

Maybe it's yellow when it uses sorry and red if it does not type check?

What are the thoughts on this.

@PatrickMassot
Copy link
Contributor

I fully agree, and this is an issue for teaching especially. My workaround is to use the Error Lens VSCode extension, but this shouldn't be required.

@Kha
Copy link
Member

Kha commented Aug 2, 2023

We already have the progress indicator, projecting errors and other diagnostics onto that as well seems like a natural solution to me. Not sure if this should be changed in the server, as the client already has all relevant data for doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants