From 928d5d2dd2f116f8142871c607a35e0d56b464a4 Mon Sep 17 00:00:00 2001 From: Kabir Baidhya Date: Mon, 3 Feb 2020 22:12:58 +0545 Subject: [PATCH 1/2] Avoid vendor specific defaults in the config Port number 1433 is for mssql only; sync-db is vendor agnostic - at least it supports mssql and pg at the moment. --- src/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/config.ts b/src/config.ts index e5fefb42..aff7ca7b 100644 --- a/src/config.ts +++ b/src/config.ts @@ -80,7 +80,7 @@ export function resolveConnectionsFromEnv(): ConnectionConfig[] { const connection = { client: process.env.DB_CLIENT, host: process.env.DB_HOST, - port: +(process.env.DB_PORT || 1433), + port: +(process.env.DB_PORT), user: process.env.DB_USERNAME, password: process.env.DB_PASSWORD, database: process.env.DB_NAME, From 5c59b0e7e9ec9b2e4c68bc85d5af91e27ff3eb11 Mon Sep 17 00:00:00 2001 From: Kabir Baidhya Date: Mon, 3 Feb 2020 22:22:32 +0545 Subject: [PATCH 2/2] Typecast to number or null --- src/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/config.ts b/src/config.ts index aff7ca7b..17d8730e 100644 --- a/src/config.ts +++ b/src/config.ts @@ -80,7 +80,7 @@ export function resolveConnectionsFromEnv(): ConnectionConfig[] { const connection = { client: process.env.DB_CLIENT, host: process.env.DB_HOST, - port: +(process.env.DB_PORT), + port: process.env.DB_PORT ? +(process.env.DB_PORT) : null, user: process.env.DB_USERNAME, password: process.env.DB_PASSWORD, database: process.env.DB_NAME,