Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Lesson with lab gets returned with lab = false (breaking commands like open and next) #3

Open
rrcobb opened this issue Feb 25, 2018 · 0 comments

Comments

@rrcobb
Copy link

rrcobb commented Feb 25, 2018

When viewing this lesson - https://github.com/learn-co-students/manipulating-hashes-web-071717 in chrome at learn.co, I tried learn next and expected to fork, clone, and open the repo, since it appears in the UI to be a lab. Similarly, after manually forking and cloning the lab, learn open opens the lab in chrome instead of the editor.

Doing a little digging led me to Learnweb::Client::Lesson and no further - I'm not sure where the code for the learn api lives, but it seems like CurrentLesson and NextLesson just save their attributes from the api response, so the logic that determines what is and is not a lab lives somewhere else!

Given that I don't know where that logic is, I'm not sure how to mark lessons as lab=true or lab=false in the lesson repo itself; it could be that this is not an issue with the learn-web client at all, but instead with the config on the lesson, or with the learn-co api that learn-web asks for the lesson.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant