Issue 10254: Improve coach tabs accessibility of Reports Lesson Tab #11606

muditchoudhary · 2023-12-09T11:53:09Z

Summary

Use KTabs to improve the accessibility of the Reports Lesson Tabs.

References

Reviewer guidance

To review, Go to Coach -->Select a Class --> Reports --> Lesson --> Select a lesson. Then test the tabs with keyboard tabs key.

Testing checklist

Contributor has fully tested the PR manually
If there are any front-end changes, before/after screenshots are included
Critical user journeys are covered by Gherkin stories
Critical and brittle code paths are covered by unit tests

PR process

PR has the correct target branch and milestone
PR has 'needs review' or 'work-in-progress' label
If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
If this is an important user-facing change, PR or related issue has a 'changelog' label
If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

Automated test coverage is satisfactory
PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

muditchoudhary · 2023-12-09T11:55:40Z

Hi, @MisRob Another one has been fixed! Please review it.

I think all the mentioned follow-up issues are fixed. Yayy 🎉

github-actions · 2023-12-09T12:27:11Z

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b13.dev0_git.552.g309e1573.pex
Windows Installer (EXE)	kolibri-0.16.0b13.dev0+git.552.g309e1573-unsigned.exe
Debian Package	kolibri_0.16.0b13.dev0+git.552.g309e1573-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b13.dev0+git.552.g309e1573-0.4.0.dmg
Android Package (APK)	kolibri-0.16.0b13.dev0+git.552.g309e1573-0.1.0-debug.apk
TAR file	kolibri-0.16.0b13.dev0+git.552.g309e1573.tar.gz
WHL file	kolibri-0.16.0b13.dev0+git.552.g309e1573-py2.py3-none-any.whl

MisRob

I think all the mentioned follow-up issues are fixed. Yayy 🎉

Yes, amazing!

Thank you @muditchoudhary, code is looking good and it seems to work well too. I added one non-blocking, nice-to-have, suggestion. And I'll also ask @radinamatic to test before we merge.

MisRob · 2023-12-14T15:06:40Z

kolibri/plugins/coach/assets/src/views/reports/ReportsLessonBase.vue

@@ -227,6 +271,12 @@
        }
      },
    },
+    $trs: {
+      coachReportsLesson: {


Apologies I forgot to mention this in previous work (and probably also use myself in the PR I recommended as a template). We're migrating away from placing strings into components. Could you please move this string to commonCoachStrings and import it from there?

In regards to importing the string, we'd appreciate if you could use this fairly new way of using setup() https://kolibri-dev.readthedocs.io/en/develop/i18n.html?highlight=translate#common-string-modules. Even though you may see translation mixins being used all over the codebase, whenever possible we'd like to use this pattern for all new code additions.

muditchoudhary · 2023-12-14T23:51:39Z

Okay I'll have a commit soon. Please wait till then before merging.

MisRob · 2023-12-15T09:38:26Z

Thank you @muditchoudhary! I also wanted to mention I won't be able to follow-up here this year as this is my last day before few weeks of time off. Someone else may jump in, but the whole team's availability will too soon be limited until the second week of January. Thank you and hopefully see you next year :)!

radinamatic · 2023-12-15T09:52:17Z

Any reason why is this PR targeted to develop instead of 0.16, as the previous one that added the same change (as far as I understand) to quiz reports?

MisRob · 2023-12-15T12:08:30Z

Any reason why is this PR targeted to develop instead of 0.16, as the previous one that added the same change (as far as I understand) to quiz reports?

@radinamatic Yes, the original intention was to target develop with all of new work. Majority of the PRs from this group target it. But the previous PR you mentioned was easier to work on the release branch because the place was broken due to some ongoing coach features.

MisRob · 2023-12-15T12:12:32Z

the place was broken due to some ongoing coach features

More accurately, a contributor couldn't create data because of broken quiz creation and therefore it was impossible to navigate to the place they needed to update because it assumed existence of at least one quiz, I believe

@muditchoudhary this is not related to your work

muditchoudhary · 2023-12-21T11:36:28Z

There was a conflict. I resolved it

muditchoudhary · 2023-12-21T11:48:16Z

Please review it. I do not exactly understand how we use string from a common module with setup.

MisRob · 2024-01-09T14:00:52Z

Thank you, @muditchoudhary. I've just returned from my vacation and will have a look at it again in the next couple of days.

muditchoudhary · 2024-01-10T05:30:08Z

Thank you, @muditchoudhary. I've just returned from my vacation and will have a look at it again in the next couple of days.

Okay. Alright. I hope you had a great vacation. Until then I'll look into some new issues. Thank you!

MisRob · 2024-01-11T17:25:15Z

The latest updates are looking good to me, thank you @muditchoudhary. @radinamatic could you please try this out?

MisRob · 2024-01-19T16:54:05Z

Hi @muditchoudhary, we'll get to test and merge this, we just need to prioritize QA of the release branch rather than the develop right now. You can consider it accepted :)

muditchoudhary · 2024-01-20T02:53:42Z

Hi @muditchoudhary, we'll get to test and merge this, we just need to prioritize QA of the release branch rather than the develop right now. You can consider it accepted :)

Okay, got it. Thank you for letting me know.

radinamatic · 2024-02-12T13:23:37Z

Installed the EXE asset from this PR on Windows 10 in both Chrome and Firefox, but I'm unable to open a report for a lesson, using neither the keyboard, nor the mouse. Report for quiz apparently opens correctly.

Firefox	Chrome
https://github.com/learningequality/kolibri/assets/1457929/514368f3-f51b-4641-be85-df9c92bcaf66

muditchoudhary · 2024-02-13T14:32:11Z

Installed the EXE asset from this PR on Windows 10 in both Chrome and Firefox, but I'm unable to open a report for a lesson, using neither the keyboard, nor the mouse. Report for quiz apparently opens correctly.

Firefox Chrome
https://github.com/learningequality/kolibri/assets/1457929/514368f3-f51b-4641-be85-df9c92bcaf66

Currently working on this: #10491 I'll check it after completing it.

MisRob · 2024-02-13T15:48:56Z

I think it will have something to do with the new way of using strings I recommended. I see you followed the documentation so if you don't mind, I would have a look @muditchoudhary rather sooner what's going on so we can eventually fix it (we'd like to use strings in this way in other work)

muditchoudhary · 2024-02-14T00:17:10Z

I think it will have something to do with the new way of using strings I recommended. I see you followed the documentation so if you don't mind, I would have a look @muditchoudhary rather sooner what's going on so we can eventually fix it (we'd like to use strings in this way in other work)

okay 👍

MisRob · 2024-02-15T12:42:14Z

@muditchoudhary We have a typo in documentation. I fixed it in this PR and will open a PR to fix documentation too. @radinamatic you can now test the page, thank you.

radinamatic · 2024-02-15T17:51:53Z

Tested with NVDA in Firefox on Windows 10, looking much better now! 👏🏽

Keyboard navigation	NVDA speech viewer

radinamatic

Manual QA & A11y testing passed, yey for more accessible tabs in Kolibri! 💯 👏🏽

Thank you for your contribution @muditchoudhary!

MisRob · 2024-02-15T18:23:30Z

Yey! Thanks @radinamatic and @muditchoudhary!

MisRob · 2024-02-15T18:23:52Z

Docs failure is not related to this PR and should be fixed on develop, so merging.

github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: medium labels Dec 9, 2023

MisRob self-requested a review December 11, 2023 07:21

MisRob approved these changes Dec 14, 2023

View reviewed changes

MisRob requested a review from radinamatic December 14, 2023 16:45

MisRob requested review from akolson and removed request for akolson December 15, 2023 09:39

marcellamaki self-requested a review December 19, 2023 16:29

muditchoudhary added 3 commits December 21, 2023 17:04

Use KDS tabs in Coach Reports Lesson tab

a243852

Fix typos and improve naming conventions

8db5b15

Fix lint

e727dd0

muditchoudhary force-pushed the issue-10254-improve-coach-tabs-accessibility branch from acb9036 to e727dd0 Compare December 21, 2023 11:35

github-actions bot added the DEV: frontend label Dec 21, 2023

Transfer string from component to commonCoach

11114d4

fix lint

331b1bd

MisRob assigned MisRob and unassigned MisRob Jan 16, 2024

rtibbles assigned radinamatic Jan 16, 2024

marcellamaki unassigned radinamatic Jan 30, 2024

bjester assigned radinamatic Jan 30, 2024

MisRob assigned MisRob and unassigned radinamatic Feb 13, 2024

Fix strings destructuring

b6f95cc

MisRob mentioned this pull request Feb 15, 2024

Fix dev docs typo #11878

Merged

9 tasks

radinamatic approved these changes Feb 15, 2024

View reviewed changes

MisRob merged commit b10ab0b into learningequality:develop Feb 15, 2024
30 of 31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 10254: Improve coach tabs accessibility of Reports Lesson Tab #11606

Issue 10254: Improve coach tabs accessibility of Reports Lesson Tab #11606

muditchoudhary commented Dec 9, 2023

muditchoudhary commented Dec 9, 2023

github-actions bot commented Dec 9, 2023 •

edited

Loading

MisRob left a comment

MisRob Dec 14, 2023

muditchoudhary commented Dec 14, 2023 •

edited

Loading

MisRob commented Dec 15, 2023

radinamatic commented Dec 15, 2023

MisRob commented Dec 15, 2023

MisRob commented Dec 15, 2023 •

edited

Loading

muditchoudhary commented Dec 21, 2023

muditchoudhary commented Dec 21, 2023

MisRob commented Jan 9, 2024

muditchoudhary commented Jan 10, 2024

MisRob commented Jan 11, 2024

MisRob commented Jan 19, 2024

muditchoudhary commented Jan 20, 2024

radinamatic commented Feb 12, 2024 •

edited

Loading

muditchoudhary commented Feb 13, 2024

MisRob commented Feb 13, 2024

muditchoudhary commented Feb 14, 2024

MisRob commented Feb 15, 2024

radinamatic commented Feb 15, 2024

radinamatic left a comment

MisRob commented Feb 15, 2024

MisRob commented Feb 15, 2024

Issue 10254: Improve coach tabs accessibility of Reports Lesson Tab #11606

Issue 10254: Improve coach tabs accessibility of Reports Lesson Tab #11606

Conversation

muditchoudhary commented Dec 9, 2023

Summary

References

Reviewer guidance

Testing checklist

PR process

Reviewer checklist

muditchoudhary commented Dec 9, 2023

github-actions bot commented Dec 9, 2023 • edited Loading

Build Artifacts

MisRob left a comment

Choose a reason for hiding this comment

MisRob Dec 14, 2023

Choose a reason for hiding this comment

muditchoudhary commented Dec 14, 2023 • edited Loading

MisRob commented Dec 15, 2023

radinamatic commented Dec 15, 2023

MisRob commented Dec 15, 2023

MisRob commented Dec 15, 2023 • edited Loading

muditchoudhary commented Dec 21, 2023

muditchoudhary commented Dec 21, 2023

MisRob commented Jan 9, 2024

muditchoudhary commented Jan 10, 2024

MisRob commented Jan 11, 2024

MisRob commented Jan 19, 2024

muditchoudhary commented Jan 20, 2024

radinamatic commented Feb 12, 2024 • edited Loading

muditchoudhary commented Feb 13, 2024

MisRob commented Feb 13, 2024

muditchoudhary commented Feb 14, 2024

MisRob commented Feb 15, 2024

radinamatic commented Feb 15, 2024

radinamatic left a comment

Choose a reason for hiding this comment

MisRob commented Feb 15, 2024

MisRob commented Feb 15, 2024

github-actions bot commented Dec 9, 2023 •

edited

Loading

muditchoudhary commented Dec 14, 2023 •

edited

Loading

MisRob commented Dec 15, 2023 •

edited

Loading

radinamatic commented Feb 12, 2024 •

edited

Loading