-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap radio buttons inside KRadioButtonGroup component #12243
Wrap radio buttons inside KRadioButtonGroup component #12243
Conversation
… CoachImmersivePage permissions handling.
Remove cruft from serializers left over from when they weren't write only. Defer as many fields as possible to backend data handling.
…roperties to exams.
Remove unneeded queries.
…and quiz data. Remove use of 'this' and refer to 'getters' to avoid an implicit coupling with the commonCoach mixin.
… a form) To simplify API and allow usage as an input component.
Replace all quiz editing with the component.
Delete unused examsRoot vuex module.
Remove unused examReport vuex module.
Fix bug by always closing the sidepanel on navigation.
Bumps [recast](https://github.com/benjamn/recast) from 0.23.7 to 0.23.9. - [Release notes](https://github.com/benjamn/recast/releases) - [Commits](benjamn/recast@v0.23.7...v0.23.9) --- updated-dependencies: - dependency-name: recast dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
@MisRob here is the PR. |
Build Artifacts
|
…dabot/npm_and_yarn/recast-0.23.9 Bump recast from 0.23.7 to 0.23.9
Limit patch updates to only things we need/are allowed to update.
Hi @radinamatic @pcenov @MisRob I have fixed that tab issue on the change language form. But I have accidentally messed with rebasing or merge in this branch. So I will push the changes for review in a new draft branch, not in this branch. |
…dabot/npm_and_yarn/kolibri-design-system-4.3.1 Bump kolibri-design-system from 4.3.0 to 4.3.1
…dabot/npm_and_yarn/espree-10.1.0 Bump espree from 10.0.1 to 10.1.0
…dabot/npm_and_yarn/launch-editor-middleware-2.7.0 Bump launch-editor-middleware from 2.6.1 to 2.7.0
…-lod-option Update LOD description in FullOrLearnOnlyDeviceForm component
Hi @muditchoudhary, thanks a lot - it seems that something unexpected happened, perhaps during the rebase? There's many unrelated files in the diff. |
@radinamatic after this ^ gets resolved and you do testing, would you also preview tab index behavior? I think @muditchoudhary utilizes setting it - I haven't seen the latest updates yet, however, if I recall right what we discussed in the first prototype, it should behave very similarly to how I implemented tabs navigation to ensure a11y. |
Yes during rebase. I don't know what happened. I did the same as I usually do. I must have missed something.
I will send the draft PR today.
Yes, I have used the same approach as we discussed the roving tab index one. |
Closing in favor of #12325 |
Summary
Wrap radio buttons of Device's setting page and Change language model inside KRadioButtonGroup. This PR is made to test this component.
…
References
…
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)