Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap radio buttons inside KRadioButtonGroup component #12243

Closed

Conversation

muditchoudhary
Copy link
Contributor

Summary

Wrap radio buttons of Device's setting page and Change language model inside KRadioButtonGroup. This PR is made to test this component.

References

Reviewer guidance

  1. Visit Device's settings page in firefox.
  2. Visit Change language model and test.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

rtibbles and others added 22 commits June 3, 2024 19:50
Remove cruft from serializers left over from when they weren't write only.
Defer as many fields as possible to backend data handling.
…and quiz data.

Remove use of 'this' and refer to 'getters' to avoid an implicit coupling with the commonCoach mixin.
… a form)

To simplify API and allow usage as an input component.
Replace all quiz editing with the component.
Delete unused examsRoot vuex module.
Remove unused examReport vuex module.
Fix bug by always closing the sidepanel on navigation.
Bumps [recast](https://github.com/benjamn/recast) from 0.23.7 to 0.23.9.
- [Release notes](https://github.com/benjamn/recast/releases)
- [Commits](benjamn/recast@v0.23.7...v0.23.9)

---
updated-dependencies:
- dependency-name: recast
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend SIZE: medium labels Jun 5, 2024
@muditchoudhary
Copy link
Contributor Author

@MisRob here is the PR.

…dabot/npm_and_yarn/recast-0.23.9

Bump recast from 0.23.7 to 0.23.9
Limit patch updates to only things we need/are allowed to update.
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: tools Internal tooling for development SIZE: very large labels Jun 19, 2024
@muditchoudhary
Copy link
Contributor Author

Hi @radinamatic @pcenov @MisRob I have fixed that tab issue on the change language form. But I have accidentally messed with rebasing or merge in this branch. So I will push the changes for review in a new draft branch, not in this branch.
We may close this draft PR.

rtibbles and others added 5 commits June 19, 2024 07:25
…dabot/npm_and_yarn/kolibri-design-system-4.3.1

Bump kolibri-design-system from 4.3.0 to 4.3.1
…dabot/npm_and_yarn/espree-10.1.0

Bump espree from 10.0.1 to 10.1.0
…dabot/npm_and_yarn/launch-editor-middleware-2.7.0

Bump launch-editor-middleware from 2.6.1 to 2.7.0
…-lod-option

Update LOD description in FullOrLearnOnlyDeviceForm component
@MisRob
Copy link
Member

MisRob commented Jun 19, 2024

Hi @muditchoudhary, thanks a lot - it seems that something unexpected happened, perhaps during the rebase? There's many unrelated files in the diff.

@MisRob
Copy link
Member

MisRob commented Jun 19, 2024

@radinamatic after this ^ gets resolved and you do testing, would you also preview tab index behavior? I think @muditchoudhary utilizes setting it - I haven't seen the latest updates yet, however, if I recall right what we discussed in the first prototype, it should behave very similarly to how I implemented tabs navigation to ensure a11y.

@muditchoudhary
Copy link
Contributor Author

it seems that something unexpected happened, perhaps during the rebase?

Yes during rebase. I don't know what happened. I did the same as I usually do. I must have missed something.

I haven't seen the latest updates yet

I will send the draft PR today.

if I recall right what we discussed in the first prototype, it should behave very similarly to how I implemented tabs navigation to ensure a11y.

Yes, I have used the same approach as we discussed the roving tab index one.

@github-actions github-actions bot added DEV: renderers HTML5 apps, videos, exercises, etc. APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) labels Jun 20, 2024
@MisRob
Copy link
Member

MisRob commented Aug 16, 2024

Closing in favor of #12325

@MisRob MisRob closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: backend Python, databases, networking, filesystem... DEV: frontend DEV: renderers HTML5 apps, videos, exercises, etc. DEV: tools Internal tooling for development SIZE: medium SIZE: very large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants