Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCheckbox/KRadioButton not showing outline when focused in keyboard navigation #4428

Closed
AlexVelezLl opened this issue Feb 5, 2024 · 7 comments · Fixed by #4443
Closed

KCheckbox/KRadioButton not showing outline when focused in keyboard navigation #4428

AlexVelezLl opened this issue Feb 5, 2024 · 7 comments · Fixed by #4443
Assignees
Labels
bug DEV: frontend help wanted Open source contributors welcome P1 - important Priority: High impact on UX TAG: a11y

Comments

@AlexVelezLl
Copy link
Member

AlexVelezLl commented Feb 5, 2024

Observed behavior

Currently, if we navigate with the keyboard, and focus on a KCheckbox or a KRadioButton, they do not show any outline, and it makes it impossible for users to know if it is really focused.

It seems to be an issue with the Kolibri Design System's globalThemeState.inputModality not recognizing that we are navigating with the keyboard, so it is returning a none outline to the $coreOutline (code).

Expected behavior

KCheckboxes and KRadioButtons should show an outline similar to this:
image

Additional information

An example of where we can find some KRadioButtons where we can test this problem is in the Studio: Settings section > Storage > Open form.

It is probably a missconfiguration of KDS in Studio, and it doesnt happen in Kolibri, so we can check Kolibri's Theme configuration as reference.

@AlexVelezLl AlexVelezLl added bug P1 - important Priority: High impact on UX DEV: frontend TAG: a11y help wanted Open source contributors welcome labels Feb 5, 2024
@Abhishekzod007
Copy link
Contributor

Hello @AlexVelezLl , I am a new contributor to this repository and I want to contribute in this so that I can solve as many issues related with this. Could you please assign this issue to me?

@AlexVelezLl
Copy link
Member Author

Hi @Abhishekzod007! Thank you for your interest of contributing to Learning Equality! Actually, I wouldnt recommend this as a first issue, since it has some dependencies with other of our products as KDS, and compare theme settings with Kolibri. If you feel confortable working with these products too let me know.

@Abhishekzod007
Copy link
Contributor

Actually I was trying to set up the studio on my local environment but encountered some issues even after trying many times, I asked about this problem on discussions section but no one replied and after sometime my request was deleted itself(don't know how?). Could you please help me to solve out that so that I will start contributing by my ownside.

@AlexVelezLl
Copy link
Member Author

@Abhishekzod007 I see that you opened this discussion some hours ago. One of our colleagues left you a suggestion to solve the problem. If that didn't work, please feel free to reopen the discussion with any update 👐

@Abhishekzod007
Copy link
Contributor

Ok , Thanks I'll let you know.

@nikkuAg
Copy link
Contributor

nikkuAg commented Feb 10, 2024

Hey, is this issue still open? I would like to work on this.

@AlexVelezLl
Copy link
Member Author

Hi @nikkuAg! I see you are facing some problems running studio, I just replied in #4171. So we can finish setting up the project first and then raise a PR for the issue you already have assigned before continuing with other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DEV: frontend help wanted Open source contributors welcome P1 - important Priority: High impact on UX TAG: a11y
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants