-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper text for the "?" in the license/source modal #4679
Comments
@radinamatic Is there an alternative, preferred way for displaying that information? Should the "About licenses" be presented as a full page? |
Been thinking about that since yesterday... 🤔 Full page is certainly a preferred option, but I'm not sure if/how that refactor and regression testing plays with our current release plans. cc @marcellamaki and @jtamiace for thoughts. |
i really don't know if this is a good idea, but what if (for the short term) we got rid of the ? and added, below, an "About licenses ⌄" small link style button, show this all inline in the modal, and then a "show less" at the bottom to close it. Not great. but perhaps better than a modal in modal, and probably much more reasonable than a more significant refactor right now. |
Removing the user string labels for string freeze/translation tracking purposes, as the strings are already present in a shared translation file. |
Yes, this looks great, @LianaHarris360, thank you! 💯 👏🏽 |
Noticed in the Aug 20 bug bash
Current behavior
The "?" seems like it should be a clickable button, and in the full screen edit modal, it is interactive.
Not sure if this was not specced, or if it just is still to be implemented, but I think this is meant to be interactive.
The text was updated successfully, but these errors were encountered: