Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable - Content library - The filters with checkboxes are not working correctly #4702

Closed
pcenov opened this issue Sep 3, 2024 · 3 comments · Fixed by #4718
Closed

Unstable - Content library - The filters with checkboxes are not working correctly #4702

pcenov opened this issue Sep 3, 2024 · 3 comments · Fixed by #4718
Assignees
Labels
bug DEV: frontend P0 - critical Priority: Release blocker or regression

Comments

@pcenov
Copy link
Member

pcenov commented Sep 3, 2024

Observed behavior

See the attached video. Most of the times when I select a value from any of the Languages, Licenses and Formats drop-downs the filter is not applied at all. Also when I click the 'Clear all' button then the checkboxes in the drop-downs remain selected. This is happening in all supported browsers.

Expected behavior

When I select a value from any of the drop-downs the filter should be applied immediately and the checkbox should be selected plus there should be displayed the tag of the selected value. When I clear any of the applied filters the corresponding checkbox should be unchecked.

Steps to reproduce the issue

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
  2. Go to the Content library and attempt to apply any of the Languages, Licenses and Formats filters

Additional information

content-library-filters.mp4

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Sep 3, 2024

@radinamatic

@akolson akolson added this to the Studio: Bulk Editing Release milestone Sep 3, 2024
@akolson akolson added bug DEV: frontend P0 - critical Priority: Release blocker or regression labels Sep 3, 2024
@akolson
Copy link
Member

akolson commented Sep 3, 2024

This is most likely related to the checkbox states issue currently being experienced after the migration from VCheckbox to KCheckbox.

@nucleogenesis
Copy link
Member

@akolson is correct here for sure - we can resolve this in the coming iteration.

Seems that some part of how Vuetify's components worked together in that part of the code has been broken.

One thing I was curious about when looking at this is whether or not the VCombobox is a suitable replacement for the fairly complex nesting of components & state found in the MultiSelect component (where the heart of this issue lies)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants