Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes - Channel trash - Clicking on 'Show more' should immediately result in showing the additional resources #4837

Closed
pcenov opened this issue Nov 22, 2024 · 6 comments
Assignees
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression

Comments

@pcenov
Copy link
Member

pcenov commented Nov 22, 2024

Observed behavior

When I click on 'Show more' it seems that nothing has happened because the newly shown resources are displayed on top of the page.

2024-11-22_16-38-49.mp4

Expected behavior

The additional resources should be shown under the already listed resources so the user can see that the button is working.

Steps to reproduce the issue

  1. Go to https://hotfixes.studio.learningequality.org/en/accounts/#/ and sign in
  2. Delete a large number of resources and open the channel's Trash page
  3. Click on 'Show more'

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Nov 22, 2024

@radinamatic

@Arunima22
Copy link
Contributor

Hello @pcenov has this issue been assigned? If not, I can work on this.

@akolson
Copy link
Member

akolson commented Nov 29, 2024

Hi @Arunima22. Unfortunately, this is a time sensitive issue for an upcoming release and thus not available for assignment. Please feel free to look out for issues in our backlog with the label help wanted -- I have already assigned you one like issue :). Thank you for your interest.

@bjester
Copy link
Member

bjester commented Dec 3, 2024

We've reversed the ordering so the oldest trashed/modified are first. I've filed a followup to address it further in a more comprehensive fix and to restore the original intended behavior. #4850

@pcenov
Copy link
Member Author

pcenov commented Dec 4, 2024

Hi @akolson when I open the Trash page for the first time it's working correctly however the second time I access it it's not. In this video I've recorded first the incorrect behavior, then I've exited the channel and returned back to the Trash page to showcase the correct behavior and finally again the incorrect one:

view-more.mp4

I guess this will be fully fixed in #4850 but mentioning it here just in case.

@bjester
Copy link
Member

bjester commented Dec 4, 2024

@pcenov That seems to be a distinctly different bug, based off what I see in the network requests. Would you please file that issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

No branches or pull requests

5 participants