From d33df6fa992cd5650fb88f08ccefaeb0e3e47ea6 Mon Sep 17 00:00:00 2001
From: Anastasios <anastas3993@gmail.com>
Date: Fri, 16 Aug 2024 16:00:12 +0400
Subject: [PATCH] fix: empty space in settings dropdown

---
 src/app/features/settings/settings.tsx | 69 +++++++++++++++-----------
 1 file changed, 40 insertions(+), 29 deletions(-)

diff --git a/src/app/features/settings/settings.tsx b/src/app/features/settings/settings.tsx
index 1dc8804d7fc..b6756b46988 100644
--- a/src/app/features/settings/settings.tsx
+++ b/src/app/features/settings/settings.tsx
@@ -1,4 +1,4 @@
-import { useState } from 'react';
+import { useMemo, useState } from 'react';
 import { useLocation, useNavigate } from 'react-router-dom';
 
 import { SettingsSelectors } from '@tests/selectors/settings.selectors';
@@ -66,6 +66,39 @@ export function Settings({ triggerButton, toggleSwitchAccount }: SettingsProps)
 
   const { isPressed: showAdvancedMenuOptions } = useModifierKey('alt', 120);
 
+  const bottomGroupItems = useMemo(
+    () =>
+      [
+        showAdvancedMenuOptions && <AdvancedMenuItems />,
+        hasKeys && walletType === 'software' && (
+          <DropdownMenu.Item
+            onSelect={() => {
+              void analytics.track('lock_session');
+              void lockWallet();
+              navigate(RouteUrls.Unlock);
+            }}
+            data-testid={SettingsSelectors.LockListItem}
+          >
+            <Flag img={<LockIcon />} textStyle="label.02">
+              Lock
+            </Flag>
+          </DropdownMenu.Item>
+        ),
+
+        hasKeys && (
+          <DropdownMenu.Item
+            onSelect={() => setShowSignOut(!showSignOut)}
+            data-testid={SettingsSelectors.SignOutListItem}
+          >
+            <Flag color="red.action-primary-default" img={<ExitIcon />} textStyle="label.02">
+              Sign out
+            </Flag>
+          </DropdownMenu.Item>
+        ),
+      ].filter(Boolean),
+    [hasKeys, lockWallet, navigate, showAdvancedMenuOptions, showSignOut, walletType]
+  );
+
   return (
     <>
       <DropdownMenu.Root>
@@ -174,35 +207,13 @@ export function Settings({ triggerButton, toggleSwitchAccount }: SettingsProps)
               </DropdownMenu.Item>
             </DropdownMenu.Group>
 
-            <Divider />
-            <DropdownMenu.Group>
-              {showAdvancedMenuOptions && <AdvancedMenuItems />}
-              {hasKeys && walletType === 'software' && (
-                <DropdownMenu.Item
-                  onSelect={() => {
-                    void analytics.track('lock_session');
-                    void lockWallet();
-                    navigate(RouteUrls.Unlock);
-                  }}
-                  data-testid={SettingsSelectors.LockListItem}
-                >
-                  <Flag img={<LockIcon />} textStyle="label.02">
-                    Lock
-                  </Flag>
-                </DropdownMenu.Item>
-              )}
+            {bottomGroupItems.length > 0 && (
+              <>
+                <Divider />
+                <DropdownMenu.Group>{...bottomGroupItems}</DropdownMenu.Group>
+              </>
+            )}
 
-              {hasKeys && (
-                <DropdownMenu.Item
-                  onSelect={() => setShowSignOut(!showSignOut)}
-                  data-testid={SettingsSelectors.SignOutListItem}
-                >
-                  <Flag color="red.action-primary-default" img={<ExitIcon />} textStyle="label.02">
-                    Sign out
-                  </Flag>
-                </DropdownMenu.Item>
-              )}
-            </DropdownMenu.Group>
             <AppVersion />
           </DropdownMenu.Content>
         </DropdownMenu.Portal>