Feature: kill switch, version warnings/messages #1411
Replies: 2 comments
-
I think it's a good solution. This will be helpful for many other features. |
Beta Was this translation helpful? Give feedback.
-
This is a great idea, especially by combining the "end of life" switch we've needed in the past for an entire product line (e.g. v3 of the wallet) with the need to deprecate specific, more minor versions of the same product line (e.g. recent Ledger app compatibility upgrades). I also agree with @beguene that we ought to behave normally if the endpoint doesn't respond or responds with invalid data. |
Beta Was this translation helpful? Give feedback.
-
Relevant for both desktop and web wallets.
Problem
Once a release has been cut, we've no channel of communication to a user of that version. This can be problematic. We've found in the past that it would be hugely helpful if we had a way of toggling a message in the UI. Further, in the case of a security vulnerability, we want a way to quickly force users to upgrade to the latest patched version.
Proposed solution
Clients could fetch JSON from a manually-maintained source, describing various messages or array of versions to kill.
Implementation
We could keep this JSON file in our repo, and fetch it using the Github API. Modifications to the files are thus subject to the same rules/checks as our code changes.
Demo json file api call
http https://raw.githubusercontent.com/blockstack/stacks-wallet-web/main/tsconfig.json
The object could look something like this. Keyed by version number (or range):
We could also create a JSON Schema, so that the file is checked at both CI-time and runtime validating the input conforms to the schema.
Beta Was this translation helpful? Give feedback.
All reactions