Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transfer to smart contract principal #3011

Open
whoabuddy opened this issue Jan 20, 2023 · 3 comments
Open

Allow transfer to smart contract principal #3011

whoabuddy opened this issue Jan 20, 2023 · 3 comments
Labels
area:send enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@whoabuddy
Copy link

This started with testing a simple Clarity contract that can stack its own STX through pool delegation.

Tried to fund the contract from the sandbox using a deposit function, but without post-conditions the deposit failed.

Next tried transferring using the Send screen of the wallet extension, which resulted in Address provided is not valid

image

Was able to get past this by writing a script, but should this type of transfer be allowed from the wallet? Maybe with a warning?

@markmhendrickson
Copy link
Collaborator

Thanks for the request. It looks like we're tracking it here as well: #2514

@kyranjamie see any reason why this wouldn't be a simple validation change? Does the wallet need to handle the recipient value differently if it contains a contract?

@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p2 Critical functionality needed by few users, with no clear alternatives area:send labels Jan 20, 2023
@kyranjamie
Copy link
Collaborator

It could be fairly straightforward, I'd need to look into it. Not 100% sure Stacks.js supports contract principals

@markmhendrickson markmhendrickson moved this from Enhancements backlog to Icebox in Hiro Wallet (DEPRECATED) Feb 18, 2023
@dartman10
Copy link

+1 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:send enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Development

No branches or pull requests

5 participants