Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show account number in avatar instead of first letter if BNS username available #3606

Closed
DeloonCasino opened this issue Apr 26, 2023 · 2 comments · Fixed by #4538
Closed

Always show account number in avatar instead of first letter if BNS username available #3606

DeloonCasino opened this issue Apr 26, 2023 · 2 comments · Fixed by #4538
Assignees
@edgarkhanzadian
Labels
area:accounts area:bns enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@DeloonCasino
Copy link

When an account has a BNS domain, it switches from "Account167" to "domain.btc" in the Switch Accounts tab.

Please add an option to show both, Account167 and domain.btc. This makes it easier when using the scrollbar to find the last edited account.

Imagine all account numbers switched from
Account154 = 785273.btc
Account155 = 857573.btc
Account156 = 427937.btc

Makes it tough to find the last position, for example while editing domains to BNSx.
@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p2 Critical functionality needed by few users, with no clear alternatives area:accounts area:bns labels Apr 27, 2023
@markmhendrickson
Copy link
Collaborator

Good suggestion!

@markmhendrickson markmhendrickson moved this to Enhancements backlog in Hiro Wallet (DEPRECATED) Apr 27, 2023
@314159265359879
Copy link
Contributor

I think this could be implemented simply by always showing the number in the sphere in front of the account instead of showing the first character of the account name in it when there is a domain name registered to it.

image

Perhaps it can be picked up together with a fix for this issue: #4483

@markmhendrickson markmhendrickson changed the title Add Account number in "Switch Accounts" menu for BNS domains Always show account number in avatar instead of first letter if BNS username available Nov 13, 2023
@edgarkhanzadian edgarkhanzadian mentioned this issue Nov 17, 2023
Merged
@pete-watters pete-watters mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgarkhanzadian edgarkhanzadian

Labels
area:accounts area:bns enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: account circle numbers and delete unused code leather-io/extension
5 participants
@markmhendrickson @pete-watters @edgarkhanzadian @314159265359879 @DeloonCasino