Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix available balance for BRC-20 while sending #4703

Closed
markmhendrickson opened this issue Dec 15, 2023 · 6 comments
Closed

Fix available balance for BRC-20 while sending #4703

markmhendrickson opened this issue Dec 15, 2023 · 6 comments
Labels
area:brc20 area:send bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds

Comments

@markmhendrickson
Copy link
Collaborator

E.g. here I'm seeing 4 BIMB under balances and in the token picker when initiating sending, but then it shows up as 0 BIMB in the form:

Screen.Recording.2023-12-15.at.07.07.04.mov
@markmhendrickson markmhendrickson added bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds area:send area:brc20 labels Dec 15, 2023
@pete-watters
Copy link
Contributor

I took a look at this and I don't have BIMB but I do have SATS. I'm just wondering if this is as the amount is so small that its basically a dust amount and you can't get rid of it?

Of my supposed 100M SATS I only have 99211647 available for transfer so I think that could be happening here

@kyranjamie
Copy link
Collaborator

Because BRC-20 operates outside the norms of bitcoin, there's no concept of dust, as far as I know (so long as the inscription transfer itself is inscribed on a UTXO above network dust threshold).

@pete-watters
Copy link
Contributor

pete-watters commented Dec 18, 2023

OK thanks Kyran!

Reading into it a bit more(via our own tooltip) and I figured out the balance we show on the asset list is:
Screenshot 2023-12-18 at 10 05 09

I tracked back this work to this PR but it's light on details

@markmhendrickson:

  • do you have some inscriptions in this wallet in bimb?
  • should we show your BRC-20 balance as the available balance

When I check in my wallet in the asset list it says I have 100M SATS but then I only have 99,211,647 available for transfer so I think that could be happening here. You can see below I have some inscriptions which are included in my asset list balance but excluded from my total balance

Screenshot 2023-12-18 at 10 13 59
Screenshot 2023-12-18 at 10 15 42

@markmhendrickson markmhendrickson self-assigned this Dec 21, 2023
@314159265359879
Copy link
Contributor

I have a wallet that has 1000 Fara
And It has a transfer inscription of 50 Fara (unused)

When I see the balance of FARA it is 1000

When I click send the available balance is 950 fara (the other 50 is already made transferable).

This is the complete situation:
$FARA balance: 1000
Transferable $FARA: 50
Available $FARA: 950

We should consider showing BRC-20 (for example $FARA) Balance and Transferable amount separately in the balance overview. Especially new users have trouble making sense of this. Some users do not realize they have already created a send inscription and the next step is to send that inscription and then they are surprised the balance is 950 instead of 1000.

@markmhendrickson
Copy link
Collaborator Author

Let's tackle this as part of the send UX redesign project more broadly.

@markmhendrickson markmhendrickson removed their assignment Jan 25, 2024
@markmhendrickson
Copy link
Collaborator Author

I'm closing this issue since we intend to disable BRC-20 sends per #5773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:brc20 area:send bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
Development

No branches or pull requests

4 participants