Block merge of PRs with failing tests

[pete-watters]

We are able to click Merge when ready on PRs that have failing tests which can introduce problems like:

• Fix testnet swaps tests #4725

I'm not sure if we can stop this happening but we should try

[kyranjamie]

I'm confused by Github's UI

I want all statuses to pas, yet it gives me the option to specify individual ones?

Gosh, it says here that yeah, you have to select them individually....

[pete-watters]

Gosh, it says here that yeah, you have to select them individually....

Yeah its a bit confusing. I think we may also need to add dev as a protected branch but I'm not sure if that would introduce other headaches?

[kyranjamie]

It already is, these are the protected branch rules. Added them manually for now, does this change your merge UI?

[pete-watters]

It has added these checks and is now blocking merge if checks aren't passing. Thanks for the quick action on this 👍

Checks show as required:

You can click Merge when ready but its not green anymore

When you click it, if the tests aren't passing then you won't be able to merge

[pete-watters]

We might need to do some more work for external contributor PRs as some of the now required checks don't pass. You can see on this PR: #4751

The test's can't pass on their PR as they don't have the required key but it would be handy if lint / prettier / typecheck can run.

We should probably change the test code back so the key is available to them. That way we could run the full suite of checks properly on their PR.

I'm happy to help do this, just wanted to add a note here

[pete-watters]

Kyran helped me understand the process for merging external PRs better so we don't need to do this. They won't be able to run all CI actions for security reasons but we have made a good improvement here blocking PRs with failing tests merging.