Fix routing for creation of new wallet from action popup

[markmhendrickson]

It currently goes to the full page view to the wrong route

routing.bug.mov

[pete-watters]

@markmhendrickson , just to confirm this.

• As a user
• WHEN I click 'Create new wallet' in the action popout
• THEN the wallet SHOULD create a new wallet
• AND land on the route /back-up-secret-key (below)

[markmhendrickson]

Yep that's my expectation. cc @mica000 to confirm UX

[mica000]

yup!

[pete-watters]

@kyranjamie I was going to change this but I just want to double check if there is a reason not to Create wallet in popup?

In WelcomePage we have some code that forces the user to go to Onboarding if they create wallet in the action popup.

I can change that but I'd like to make sure it doesn't introduce a regression.

 const startOnboarding = useCallback(async () => {
    if (isPopupMode()) {
      openIndexPageInNewTab(RouteUrls.Onboarding);
      closeWindow();
      return;
    }
    setIsGeneratingWallet(true);

[kyranjamie]

Yeah, was added intentionally. All it takes it one click to accidentally close the extension, then you have to start again (unless we manage a lot more onboarding state). Further, it's just generally a worse user experience to do it in a tiny mobile-sized viewport, when you could instead use a full page view.

[pete-watters]

OK thanks Kyran. @markmhendrickson I won't change this as per comment above

[markmhendrickson]

We still want to fix the routing though don't we? In that, the user indeed needs the full page view to open, but to the key generation screen, not getting started one.

[pete-watters]

In the code we are doing a re-direct before creating anything.

I can change it but we will first have to create the new wallet in the extension and then do the re-direction.

const startOnboarding = useCallback(async () => {
    if (isPopupMode()) {
      openIndexPageInNewTab(RouteUrls.Onboarding);
      closeWindow();
      return;
    }
    setIsGeneratingWallet(true);
    // #4517 signout other tabs on wallet create
    await keyActions.signOut();
    keyActions.generateWalletKey();
    void analytics.track('generate_new_secret_key');
    if (decodedAuthRequest) {
      navigate(RouteUrls.SetPassword);
    }
    navigate(RouteUrls.BackUpSecretKey);
  }, [keyActions, analytics, decodedAuthRequest, navigate]);

I think this should be OK, but maybe @kyranjamie has better insights here.

To be clear, this is for creation of a new wallet, not recovery of a key.

[pete-watters]

@kyranjamie - is it OK if I make this change so that:

• when users click Create account in extension mode
• we actually create the wallet for them and bring them here

You confirmed this was done intentionally here but Mark thinks we should still change it

[kyranjamie]

Mark and I are discussing complimentary, not contradictory, behaviours in these comments. I was saying that we should force the user to go to full screen mode. Mark is saying, yes do that, but take them directly to the save secret key page not the welcome page.

It is not a discussion about begin able to do onboarding entirely in the action popup.