Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Brc20 & Rune prices #5603

Closed
cbadawi opened this issue Jul 4, 2024 · 4 comments
Closed

Display Brc20 & Rune prices #5603

cbadawi opened this issue Jul 4, 2024 · 4 comments
Labels
enhancement enhancement-p1 Critical functionality needed by many users, with no clear alternatives

Comments

@cbadawi
Copy link
Contributor

cbadawi commented Jul 4, 2024

You might need a backend proxy, a DB, a caching mechanism etc ... for this to hide the API key of the prices provider.

It might be a big task but I think it would really boost the user experience (mine at least :) ).

again, happy to work on this.

@314159265359879 314159265359879 added enhancement-p1 Critical functionality needed by many users, with no clear alternatives enhancement labels Jul 4, 2024
@markmhendrickson
Copy link
Collaborator

I believe this data is all provided by the Best in Slot API, which is already integrated so it'd be a matter of adding support for the relevant endpoint: https://docs.bestinslot.xyz/reference/api-reference/ordinals-and-brc-20-and-runes-and-bitmap-v3-api-mainnet+testnet+signet

@cbadawi
Copy link
Contributor Author

cbadawi commented Jul 7, 2024

Nice. I can give it a go after the manage-tokens pr merges.

@brandonmarshall-tm
Copy link

BRC20 prices were previously supported but a later update broke it, should be back up soon: #5626

Fiat value for Runes we have an existing request here: #5300

Runes is a highly requested feature! Would love to see this happen.

@markmhendrickson
Copy link
Collaborator

I'm closing out this issue in favor of the others linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement-p1 Critical functionality needed by many users, with no clear alternatives
Projects
None yet
Development

No branches or pull requests

4 participants