Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When I edit network settings I expect to see the current data not default data #5795

Closed
314159265359879 opened this issue Aug 21, 2024 · 3 comments · Fixed by #5871
Closed

When I edit network settings I expect to see the current data not default data #5795

314159265359879 opened this issue Aug 21, 2024 · 3 comments · Fixed by #5871
Assignees
@alter-eggo
Labels
area:networks bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds effort:small Expected to take up to 1 day of integration work sprint:2024-09-02

Comments

@314159265359879
Copy link
Contributor

Here I added stacks granite API, then when I edit the Stacks API url shown as the hiro api url again. I expect to see leather.granite.world there. Expected:
image

To reproduce.

  1. Top right corner menu
  2. click network
  3. add network, any name, use leather.granite.world for the stacks API, leave rest unchanged but ad a unique bitcoin key for example 335
  4. Then add network
  5. top right corner menu again
  6. click network
  7. go to three dots and click... to "edit" next to the granite network you just added
  8. See error

Video from 6 onwards:

2024-08-21_15-32-35.mp4
@314159265359879 314159265359879 added bug Functionality broken bug-p4 Non-critical functionality broken for few users, or there are clear workarounds labels Aug 21, 2024
@markmhendrickson markmhendrickson added area:networks bug-p2 Critical functionality broken for few users, with no clear workarounds and removed bug-p4 Non-critical functionality broken for few users, or there are clear workarounds labels Aug 21, 2024
@markmhendrickson
Copy link
Collaborator

Let's add an integration test when resolving

@markmhendrickson
Copy link
Collaborator

While fixing this, we should also update the title and button label to "Edit network" since it says "Add network" atm when editing a network:

Screen.Recording.2024-08-26.at.13.23.22.mov

@markmhendrickson
Copy link
Collaborator

Related visual fix:

One of these links has a visual treatment (underline) but the other doesn't for some reason

Image

@alter-eggo alter-eggo added the effort:small Expected to take up to 1 day of integration work label Sep 4, 2024
alter-eggo added a commit that referenced this issue Sep 24, 2024
@alter-eggo
fix: edit network urls, closes #5795
df33bd4
@alter-eggo alter-eggo linked a pull request Sep 24, 2024 that will close this issue
fix: edit network wrong urls #5871
Merged
alter-eggo added a commit that referenced this issue Sep 24, 2024
@alter-eggo
fix: edit network urls, closes #5795
59f59b0
alter-eggo added a commit that referenced this issue Sep 25, 2024
@alter-eggo
fix: edit network urls, closes #5795
2eff833
alter-eggo added a commit that referenced this issue Sep 26, 2024
@alter-eggo
fix: edit network urls, closes #5795
e10bdd3
alter-eggo added a commit that referenced this issue Sep 26, 2024
@alter-eggo
fix: edit network urls, closes #5795
8be00ee
github-merge-queue bot pushed a commit that referenced this issue Sep 26, 2024
@alter-eggo
fix: edit network urls, closes #5795
7256379
kyranjamie pushed a commit that referenced this issue Oct 7, 2024
@semantic-release-bot
chore(release): 6.48.0
24425d1 
## [6.48.0](v6.47.1...v6.48.0) (2024-10-07)

### Features

* add inscription send flow testing, closes leather-io/issues[#191](#191) ([54fce3e](54fce3e))
* add option to hide balance, closes leather-io[#5096](#5096) ([32b064f](32b064f))
* bitflow implemenation, closes leather-io/issues[#99](#99) ([9c0a6e8](9c0a6e8))
* redesign connection flow, closes leather.io/issues[#283](#283) ([0717b12](0717b12))

### Bug Fixes

* **analytics:** initial route only used in report analytics ([a253390](a253390))
* broken styles ([cc6edb5](cc6edb5))
* edit network urls, closes leather-io/extension[#5795](#5795) ([7256379](7256379))
* path-to-regexp vulnerability GHSA-9wv6-86v2-598j ([36a84dc](36a84dc))
* refactor add network to use card footer, closes leather-io/issues[#313](#313) ([68de602](68de602))
* secret key stored cleartext in memory ([e0bdec9](e0bdec9))
* security audit failures ([d4c8b48](d4c8b48))
* show transaction amount above Increase Fee, closes [#5826](#5826) ([0a61651](0a61651))
* storybook icons, closes leather-io/issues[#294](#294) ([a0b30eb](a0b30eb))
* update manifest description, closes leather-io/issues[#310](#310) ([3450e0a](3450e0a))

### Internal

* blockchain model ([6bbb1fa](6bbb1fa))
* currency model imports ([54e2865](54e2865))
* pin node < v22 ([27f3b67](27f3b67))
* post-release merge back ([2b6bc91](2b6bc91))
* remove brc20 send flow code ([ad2d69f](ad2d69f))
* update wbip004 method name, closes [#5866](#5866) ([d0873e8](d0873e8))
* update webpack ([da58aa7](da58aa7))
* upgrade pnpm ([fb5a46f](fb5a46f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alter-eggo alter-eggo

Labels
area:networks bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds effort:small Expected to take up to 1 day of integration work sprint:2024-09-02
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: edit network wrong urls leather-io/extension
3 participants
@markmhendrickson @314159265359879 @alter-eggo