test: removing babel #4560
Merged
test: removing babel #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
experimental/remove-babel
branch
from
343d17a to
0425d24
Compare
kyranjamie
force-pushed
the
experimental/remove-babel
branch
from
0425d24 to
e51e710
Compare
|
How about just merging this to get rid of |
pete-watters
approved these changes
Nov 28, 2023
Merged
|
@pete-watters can you checkout & confirm sanity check it's working correctly? Then happy to merge |
I tested it last week, trying and failing to get the bonus points. I retested now and LGTM. I can build the APP and things look the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone please feel free to have a play around with these settings as well.
I was under the impression removing babel would drastically speed up the build. It doesn't, though still removes a handful of packages.
Bonus points if anyone can get
yarn buildsub 5s and the dev build to rebuild within 1s.