Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark ui bugs #4578

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix: mark ui bugs #4578

merged 1 commit into from
Nov 28, 2023

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Nov 27, 2023

Try out this version of Leather — download extension builds.

Fixes minor UI bugs.

@fbwoolf fbwoolf linked an issue Nov 27, 2023 that may be closed by this pull request
@fbwoolf
Copy link
Contributor Author

fbwoolf commented Nov 28, 2023

@markmhendrickson this is broken in prod too, I fixed but had to make the text really small to fit. Ok? cc @mica000

Screenshot 2023-11-27 at 4 32 18 PM

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Nov 28, 2023

Fixed this too @markmhendrickson, sorry about that! It was hardcoded during the UI refactor. 🙃

image

@@ -4,6 +4,14 @@ import { Box } from 'leather-styles/jsx';

import { isBigInt, isTypedArray } from '@shared/utils';

export function parseJson(content: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor 👍

@pete-watters pete-watters added this pull request to the merge queue Nov 28, 2023
Merged via the queue into dev with commit e9da651 Nov 28, 2023
26 checks passed
@pete-watters pete-watters deleted the fix/mark-ui-bugs branch November 28, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark's stacks/ui-removal visual feedback
2 participants