fix: allow users to click into text input fields when ::before border #4584

pete-watters · 2023-11-28T11:24:54Z

Try out this version of Leather — download extension builds.

fix: allow users to click into text input fields when ::before border is triggered

Kapture.2023-11-28.at.11.24.35.mp4

pete-watters · 2023-11-28T11:26:31Z

src/app/components/text-input-field.tsx

@@ -58,11 +57,6 @@ export function TextInputField({
        }}
        border="default"
        borderRadius="sm"
-        className={css({


I just got rid of this as it wasn't working and hasn't been for a while. I opened a task for it #4583

kyranjamie

I fixed in Ledger PR adding pointEvents none to before, but this works too if we're not using the focus.

@fabric-8 @mica000 should the field have a focus state change the border?

pete-watters requested review from fbwoolf, kyranjamie and edgarkhanzadian November 28, 2023 11:24

pete-watters force-pushed the fix/recipient-before branch from 1c69759 to 0420c86 Compare November 28, 2023 11:25

pete-watters commented Nov 28, 2023

View reviewed changes

pete-watters added 2 commits November 28, 2023 11:27

fix: allow users to click input when populated, closes #4582

b3a900d

fix: remove not working onFocusborder, to be fixed in #4583

74e3af1

pete-watters force-pushed the fix/recipient-before branch from 0420c86 to 74e3af1 Compare November 28, 2023 11:27

pete-watters linked an issue Nov 28, 2023 that may be closed by this pull request

Field focus blocked by ::before #4582

Closed

pete-watters self-assigned this Nov 28, 2023

pete-watters added the bug Functionality broken label Nov 28, 2023

kyranjamie approved these changes Nov 28, 2023

View reviewed changes

pete-watters added this pull request to the merge queue Nov 28, 2023

Merged via the queue into dev with commit cddf09b Nov 28, 2023
26 checks passed

pete-watters deleted the fix/recipient-before branch November 28, 2023 12:31

Provide feedback