fix: swaps test and others #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
force-pushed
the
fix/swaps-test
branch
from
a965dc7 to
ed59fcb
Compare
fbwoolf
force-pushed
the
fix/swaps-test
branch
from
ed59fcb to
7db0784
Compare
fbwoolf
commented
Dec 19, 2023
| @@ -53,6 +53,7 @@ test.describe('Transaction signing', () => { | |||
| const multiSignatureTxHex = await generateMultisigUnsignedStxTransfer( | |||
| TEST_ACCOUNT_2_STX_ADDRESS, | |||
| amount, | |||
| 100, | |||
There was a problem hiding this comment.
This test was failing bc the high fee warning popup was being triggered w/out a fee provided.
fbwoolf
commented
Dec 19, 2023
| @@ -31,6 +24,14 @@ test.describe('Transaction signing', () => { | |||
| test('that it validates against insufficient funds when performing a contract call', async ({ | |||
| context, | |||
| }) => { | |||
| const accountsPage = await context.waitForEvent('page'); | |||
| await accountsPage.locator('text="Account 2"').click(); | |||
There was a problem hiding this comment.
Account 1 in the test account doesn't have a 0 balance atm so this was failing.
There was a problem hiding this comment.
Should we fill it up instead of making this change?
There was a problem hiding this comment.
I think the problem was Account 1 has funds so clicking on Account 2 which doesn't solves it
|
Fixed a few other failing tests here. |
kyranjamie
approved these changes
Dec 19, 2023
| @@ -1,12 +1,12 @@ | |||
| import { test } from '../../fixtures/fixtures'; | |||
|
|
|||
| const alexSdkPostRoute = 'https://*.alexlab.co/v1/graphql'; | |||
| const hiroApiPostRoute = '*/**/v2/transactions'; | |||
There was a problem hiding this comment.
also possible to be specific to Hiro api origin, too?
| @@ -31,6 +24,14 @@ test.describe('Transaction signing', () => { | |||
| test('that it validates against insufficient funds when performing a contract call', async ({ | |||
| context, | |||
| }) => { | |||
| const accountsPage = await context.waitForEvent('page'); | |||
| await accountsPage.locator('text="Account 2"').click(); | |||
There was a problem hiding this comment.
Should we fill it up instead of making this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to test swaps on mainnet bc we hide swaps on testnet. The broadcast is caught and aborted, so it should be ok. I also just did some clean up of the locators and handled if there happens to be a pending tx (which means we needed to catch the Hiro api post route).