Containers refactor III - This time its composable

[pete-watters]

Try out Leather build d804675 — Extension build, Test report, Storybook, Chromatic

This PR addresses some concerns around how I implemented adding global containers. See discussion here.

• The original PR I added was Full page extension views, containers, shared headers + footers #4655
• After another attempt using Context here, now each page is responsible for defining it's own header via composition.

There is a lot of code here but the main update is:

• use of routes to configure app/features/container is now gone
• Pages get have to opt in and configure their own header - <MainHeader, <PageHeader, <PopupHeader
• <Home pages have this set @ app-route level as they share a simpler header
• Other full view pages use the <Page wrapper to control their width:

<Container>
    <PageHeader title="Send" />
    <ContainerLayout>
          <Content>
                <Page>
                </Page>
          </Content>
      </ContainerLayout>    
   </Container>     

• <Popup pages are popup windows for Approval UX and don't need the <Page wrapper

This is an improvement but could probably be improved more so please let me know of any suggestions.

[markmhendrickson]

Thanks for taking this initiative, @pete-watters. Is it worth getting some reviewer eyes on this now for feedback, despite it being a draft PR still?

[pete-watters]

Thanks for taking this initiative, @pete-watters. Is it worth getting some reviewer eyes on this now for feedback, despite it being a draft PR still?

I'm working on a final fix for Popup's then I will open for full review in the next hour no matter what 👍

[pete-watters]

Thanks for taking this initiative, @pete-watters. Is it worth getting some reviewer eyes on this now for feedback, despite it being a draft PR still?

I'm working on a final fix for Popup's then I will open for full review in the next hour no matter what 👍

OK it turns out everything was working and the problem was solved by a lunch break

[pete-watters]

@kyranjamie @alter-eggo : Can you please check this PR when you have some time?

Its quite large so apologies for that but hopefully it adds a big improvement to the scalability of the container pattern

[pete-watters]

I can refactor <MainHeader and <PageHeader to merge them and keep them DRY but didn't want to let this drag on longer before review

[kyranjamie]

Thanks Pete, this looks like a well organised, configurable solution 👍🏻