fix: axios get request for config

leather-io · Nov 20, 2023 · 3ad4b06 · 3ad4b06
1 parent 6b75267
commit 3ad4b06
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/src/app/features/hiro-messages/in-app-messages.tsx b/src/app/features/hiro-messages/in-app-messages.tsx
@@ -1,14 +1,14 @@
 import { Flex, FlexProps } from 'leather-styles/jsx';
 
-import { useRemoteHiroMessages } from '@app/query/common/remote-config/remote-config.query';
+import { useRemoteLeatherMessages } from '@app/query/common/remote-config/remote-config.query';
 import { useCurrentNetworkState } from '@app/store/networks/networks.hooks';
 import { useDismissMessage } from '@app/store/settings/settings.actions';
 import { useDismissedMessageIds } from '@app/store/settings/settings.selectors';
 
 import { HiroMessageItem } from './components/in-app-message-item';
 
 export function InAppMessages(props: FlexProps) {
-  const messages = useRemoteHiroMessages();
+  const messages = useRemoteLeatherMessages();
 
   const { mode } = useCurrentNetworkState();
   const dismissMessage = useDismissMessage();

diff --git a/src/app/query/common/remote-config/remote-config.query.ts b/src/app/query/common/remote-config/remote-config.query.ts
@@ -74,14 +74,15 @@ const githubWalletConfigRawUrl = `https://raw.githubusercontent.com/${GITHUB_ORG
   BRANCH_NAME || defaultBranch
 }/config/wallet-config.json`;
 
-async function fetchHiroMessages(): Promise<RemoteConfig> {
+async function fetchLeatherMessages(): Promise<RemoteConfig> {
   if ((!BRANCH_NAME && WALLET_ENVIRONMENT !== 'production') || IS_TEST_ENV)
     return localConfig as RemoteConfig;
-  return axios.get(githubWalletConfigRawUrl);
+  const resp = await axios.get(githubWalletConfigRawUrl);
+  return resp.data;
 }
 
 function useRemoteConfig() {
-  const { data } = useQuery(['walletConfig'], fetchHiroMessages, {
+  const { data } = useQuery(['walletConfig'], fetchLeatherMessages, {
     // As we're fetching from Github, a third-party, we want
     // to avoid any unnecessary stress on their services, so
     // we use quite slow stale/retry times
@@ -91,7 +92,7 @@ function useRemoteConfig() {
   return data;
 }
 
-export function useRemoteHiroMessages(): HiroMessage[] {
+export function useRemoteLeatherMessages(): HiroMessage[] {
   const config = useRemoteConfig();
   return get(config, 'messages.global', []);
 }

diff --git a/tests/specs/settings/settings-menu.spec.ts b/tests/specs/settings/settings-menu.spec.ts
@@ -64,7 +64,7 @@ test.describe('Settings menu', () => {
     test.expect(currentNetwork).toContain('mainnet');
 
     await page.getByTestId(SettingsSelectors.ChangeNetworkAction).click();
-    await page.waitForTimeout(850);
+    await page.waitForTimeout(1000);
     const networkListItems = await page.getByTestId(SettingsSelectors.NetworkListItem).all();
     test.expect(networkListItems).toHaveLength(5);
   });